Bug 93718 - New test introduced in r125262 css3/flexbox/inline-flex-crash2.html fails
Summary: New test introduced in r125262 css3/flexbox/inline-flex-crash2.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 77772 87008
  Show dependency tree / graph
 
Reported: 2012-08-10 06:18 PDT by Zoltan Arvai
Modified: 2012-08-12 03:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2012-08-10 11:24 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2012-08-10 06:18:12 PDT 
css3/flexbox/inline-flex-crash2.html fails on Qt, EFL, GTK


--- /ramdisk/qt-linux-release/build/layout-test-results/css3/flexbox/inline-flex-crash2-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/css3/flexbox/inline-flex-crash2-actual.txt 
@@ -1,5 +1,25 @@
-This test passes if it doesn't crash.
-
-AAAA
-
-A
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x209
+  RenderBlock {HTML} at (0,0) size 800x209
+    RenderBody {BODY} at (8,8) size 784x193
+      RenderBlock (anonymous) at (0,0) size 784x19
+        RenderText {#text} at (0,0) size 203x19
+          text run at (0,0) width 203: "This test passes if it doesn't crash."
+      RenderBlock {DIV} at (0,41) size 784x152
+        RenderBlock {H5} at (0,0) size 784x30
+          RenderInline {A} at (0,0) size 0x15
+            RenderImage {IMG} at (0,12) size 0x0
+            RenderBR {BR} at (0,0) size 0x15
+          RenderText {#text} at (0,15) size 36x15
+            text run at (0,15) width 36: "AAAA"
+        RenderBlock (anonymous) at (0,52) size 784x100
+          RenderInline {A} at (0,0) size 8x19
+            RenderFlexibleBox {DIV} at (0,0) size 8x100
+              RenderBlock {PRE} at (0,13) size 8x74
+                RenderInline (generated) at (0,0) size 8x15
+                  RenderText {#text} at (0,0) size 8x15
+                    text run at (0,0) width 8: "A"
+                RenderText {#text} at (0,0) size 0x0
+selection start: position 0 of child 0 {IMG} of child 0 {A} of child 0 {H5} of child 1 {DIV} of body
+selection end:   position 4 of child 1 {#text} of child 0 {H5} of child 1 {DIV} of body
Comment 1 Zoltan Arvai 2012-08-10 06:39:01 PDT 
Skipped on QT, r125274: <http://trac.webkit.org/changeset/125274>
Please unskip it with proper fix.
Comment 2 Zan Dobersek 2012-08-10 10:29:29 PDT 
The test uses window.layoutTestController instead of window.testRunner. The issue was raised at https://bugs.webkit.org/show_bug.cgi?id=77772#c23. It probably should just be changed to window.testRunner.
Comment 3 Ojan Vafai 2012-08-10 11:24:39 PDT 
Created attachment 157766 [details]
Patch
Comment 4 Ojan Vafai 2012-08-10 11:24:56 PDT 
Committed r125302: <http://trac.webkit.org/changeset/125302>
Comment 5 Tony Chang 2012-08-10 15:50:40 PDT 
Sorry about that.  Thanks for fixing.
Comment 6 Eric Seidel (no email) 2012-08-12 03:03:32 PDT 
Comment on attachment 157766 [details]
Patch

Cleared review? from attachment 157766 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).