Bug 93710 - [WK2] Add getter for capture attribute of input element
Summary: [WK2] Add getter for capture attribute of input element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Kihong Kwon
URL: http://www.w3.org/TR/html-media-capture/
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-10 04:25 PDT by Kihong Kwon
Modified: 2012-08-14 00:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.76 KB, patch)
2012-08-10 05:02 PDT, Kihong Kwon
no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2012-08-12 23:57 PDT, Kihong Kwon
tonikitoo: review+
Details | Formatted Diff | Diff
Patch for landing. (5.51 KB, patch)
2012-08-13 23:08 PDT, Kihong Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-08-10 04:25:27 PDT
Add getter for capture attribute to WKOpenPanelParameters to support Media Capture.
Comment 1 Kihong Kwon 2012-08-10 05:02:12 PDT
Created attachment 157709 [details]
Patch
Comment 2 Kihong Kwon 2012-08-12 23:57:19 PDT
Created attachment 157929 [details]
Patch
Comment 3 Chris Dumez 2012-08-13 05:50:00 PDT
Comment on attachment 157929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review

> Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66
> +#if ENABLE(MEDIA_CAPTURE)

Why not include the whole function definition in the #ifdef ?

> Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53
> +    return toCopiedAPI(toImpl(parametersRef)->capture());

Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined?

> Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46
> +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes);

"parameters"
Comment 4 Antonio Gomes 2012-08-13 05:53:42 PDT
Comment on attachment 157929 [details]
Patch

looks sane.
Comment 5 Kihong Kwon 2012-08-13 22:20:35 PDT
(In reply to comment #3)
> (From update of attachment 157929 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review
> 
> > Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66
> > +#if ENABLE(MEDIA_CAPTURE)
> 
> Why not include the whole function definition in the #ifdef ?
> 
> > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53
> > +    return toCopiedAPI(toImpl(parametersRef)->capture());
> 
> Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined?
> 
> > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46
> > +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes);
> 
> "parameters"

Done. Thanks! :)
Comment 6 Kihong Kwon 2012-08-13 23:08:56 PDT
Created attachment 158226 [details]
Patch for landing.
Comment 7 WebKit Review Bot 2012-08-14 00:18:09 PDT
Comment on attachment 158226 [details]
Patch for landing.

Clearing flags on attachment: 158226

Committed r125512: <http://trac.webkit.org/changeset/125512>
Comment 8 WebKit Review Bot 2012-08-14 00:18:14 PDT
All reviewed patches have been landed.  Closing bug.