Bug 93706 – Support creating File object from FileSystem URL for files in FileSystem API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kinuko Yasuda]

Support creating File object from FileSystem URL for files in FileSystem API.

Current File code assumes the existence of local file (i.e. needs a platform local file path to work appropriately) but for FileSystem files it may not be always the case.
Some implementation may want to use in-memory filesystem to realize sandboxed filesystem, or the filesystem may exist in a remote server so that there may not be the local platform file.

We should support File object creation not only from file path but from FileSystem URL, and should make File object keep the information, so that the platform-specific code can handle file requests more appropriately.

[Kinuko Yasuda]

Created attachment 157698 [details]
wip

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Early Warning System Bot]

Comment on attachment 157698 [details]
wip

Attachment 157698 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13459920

[Early Warning System Bot]

Comment on attachment 157698 [details]
wip

Attachment 157698 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13477157

[Build Bot]

Comment on attachment 157698 [details]
wip

Attachment 157698 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13470547

[Gyuyoung Kim]

Comment on attachment 157698 [details]
wip

Attachment 157698 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13463662

[Kinuko Yasuda]

Created attachment 157722 [details]
Patch

[Build Bot]

Comment on attachment 157722 [details]
Patch

Attachment 157722 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13477196

[Kinuko Yasuda]

Created attachment 157729 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 157729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157729&action=review

> Source/Platform/chromium/public/WebBlobData.h:53
> +        WebURL url; // For Blob or URL.

nit: "For TypeBlob or TypeURL." just to make it really clear.

> Source/Platform/chromium/public/WebHTTPBody.h:57
> +        WebURL url; // For Blob or URL type.

nit: "For TypeBlob or TypeURL." just to make it really clear.

> Source/WebCore/platform/chromium/support/WebHTTPBody.cpp:157
> +    ASSERT(KURL(blobURL).protocol() == "blob");

nit: use KURL's protocolIs method.

[Kinuko Yasuda]

Committed r125391: <http://trac.webkit.org/changeset/125391>