Bug 93699 - Web Inspector: add frame ids to TimeStamp, Time and TimeEnd records in Timeline
Summary: Web Inspector: add frame ids to TimeStamp, Time and TimeEnd records in Timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-10 01:19 PDT by Andrey Kosyakov
Modified: 2012-08-10 06:44 PDT (History)
10 users (show)

See Also:

Attachments
Patch (16.52 KB, patch)
2012-08-10 01:31 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-08-10 01:19:42 PDT 
This plumbs frame from Console to Timeline and uses it to add frameId fields to the following records:

- TimeStamp
- Time
- TimeEnd
Comment 1 Andrey Kosyakov 2012-08-10 01:31:43 PDT 
Created attachment 157673 [details]
Patch
Comment 2 Pavel Feldman 2012-08-10 03:06:32 PDT 
What is the motivation behind this change?
Comment 3 Andrey Kosyakov 2012-08-10 03:10:23 PDT 
(In reply to comment #2)
> What is the motivation behind this change?

Consistency with the rest of the timeline -- we try to provide frame ids for each record that is frame-specific. This will let clients filter only relevant frames.
Comment 4 Andrey Kosyakov 2012-08-10 06:44:21 PDT 
Committed r125277: <http://trac.webkit.org/changeset/125277>