Bug 93697 - Web Inspector: console.timeStamp() marked are not shown in Timeline overview
Summary: Web Inspector: console.timeStamp() marked are not shown in Timeline overview
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-10 00:45 PDT by Andrey Kosyakov
Modified: 2012-08-10 06:27 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2012-08-10 00:48 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (7.81 KB, patch)
2012-08-10 02:24 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-08-10 00:45:55 PDT 
0. Open Web Inspector, switch to the Timeline panel
1. Start timeline
2. Type console.timeStamp("foo") in console
3. Stop timeline
4. Note timestamp events appear in the detailed view
4. Note there are no orange vertical markers for the timestamp events in the time bars of either overview or detailed view.

This is a regression introduced at r119826 (http://trac.webkit.org/changeset/119826) -- timestamp events currently don't have a frame id. They probably should, but we should display timestamp for all frames anyway.
Comment 1 Andrey Kosyakov 2012-08-10 00:48:22 PDT 
Created attachment 157657 [details]
Patch
Comment 2 Pavel Feldman 2012-08-10 00:52:38 PDT 
Comment on attachment 157657 [details]
Patch

A test?
Comment 3 Andrey Kosyakov 2012-08-10 02:24:09 PDT 
Created attachment 157689 [details]
Patch
Comment 4 Andrey Kosyakov 2012-08-10 06:27:00 PDT 
Committed r125272: <http://trac.webkit.org/changeset/125272>