WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93685
WebCore::findAtomicString(PropertyName) always convert the name to 16bits
https://bugs.webkit.org/show_bug.cgi?id=93685
Summary
WebCore::findAtomicString(PropertyName) always convert the name to 16bits
Benjamin Poulain
Reported
2012-08-09 21:30:44 PDT
PropertyName is generally 8bits, we should not convert the string.
Attachments
Patch
(8.39 KB, patch)
2012-08-09 21:43 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch
(8.11 KB, patch)
2012-08-10 12:27 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-08-09 21:43:20 PDT
Created
attachment 157634
[details]
Patch
Benjamin Poulain
Comment 2
2012-08-09 21:44:51 PDT
According to DTrace this is only ~8 microseconds per call, but hopefully this will save some memory.
Geoffrey Garen
Comment 3
2012-08-09 21:56:54 PDT
Comment on
attachment 157634
[details]
Patch r=me
Build Bot
Comment 4
2012-08-09 22:14:35 PDT
Comment on
attachment 157634
[details]
Patch
Attachment 157634
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/13460815
Benjamin Poulain
Comment 5
2012-08-10 12:27:05 PDT
Created
attachment 157789
[details]
Patch
Benjamin Poulain
Comment 6
2012-08-11 14:12:41 PDT
Committed
r125356
: <
http://trac.webkit.org/changeset/125356
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug