Bug 93663 - Crash exiting from HTML5 FS mode to normal mode via ESC key
Summary: Crash exiting from HTML5 FS mode to normal mode via ESC key
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 15:45 PDT by Jer Noble
Modified: 2012-08-13 16:30 PDT (History)
0 users

See Also:

Attachments
Patch (2.01 KB, patch)
2012-08-09 15:50 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-08-09 15:45:51 PDT 
Crash exiting from HTML5 FS mode to normal mode via ESC key
Comment 1 Jer Noble 2012-08-09 15:50:10 PDT 
Created attachment 157568 [details]
Patch
Comment 2 Jer Noble 2012-08-10 13:16:59 PDT 
Committed r125319: <http://trac.webkit.org/changeset/125319>
Comment 3 Darin Adler 2012-08-13 14:55:06 PDT 
Comment on attachment 157568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157568&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-148
> -        _watchdogTimer = adoptNS([NSTimer scheduledTimerWithTimeInterval:DefaultWatchdogTimerInterval target:self selector:@selector(exitFullScreen) userInfo:nil repeats:NO]);

Or you could just take out the adoptNS and do a straight assignment. That would also work.
Comment 4 Jer Noble 2012-08-13 16:30:38 PDT 
(In reply to comment #3)
> (From update of attachment 157568 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157568&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-148
> > -        _watchdogTimer = adoptNS([NSTimer scheduledTimerWithTimeInterval:DefaultWatchdogTimerInterval target:self selector:@selector(exitFullScreen) userInfo:nil repeats:NO]);
> 
> Or you could just take out the adoptNS and do a straight assignment. That would also work.

I considered that, but I was simultaneously getting rid of the autorelease.