Bug 93662 - Allow users to specify a different hover image for TextFieldDecorationElement
Summary: Allow users to specify a different hover image for TextFieldDecorationElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 15:15 PDT by Garrett Casto
Modified: 2012-10-09 06:43 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.36 KB, patch)
2012-08-09 15:19 PDT, Garrett Casto 		no flags Details | Formatted Diff | Diff
Patch (9.23 KB, patch)
2012-08-12 02:53 PDT, Garrett Casto 		no flags Details | Formatted Diff | Diff
Patch (9.22 KB, patch)
2012-10-08 15:33 PDT, Garrett Casto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Casto 2012-08-09 15:15:16 PDT 
Allow users to specify a different hover image for TextFieldDecorationElement
Comment 1 Garrett Casto 2012-08-09 15:19:08 PDT 
Created attachment 157559 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-09 15:22:08 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Kent Tamura 2012-08-09 18:46:09 PDT 
Comment on attachment 157559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157559&action=review

The code change looks good.

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please replace this line with something or remove this line.  r- because of this.
Comment 4 Garrett Casto 2012-08-12 02:53:27 PDT 
Created attachment 157893 [details]
Patch
Comment 5 Kent Tamura 2012-08-12 06:22:41 PDT 
Comment on attachment 157893 [details]
Patch

ok
Comment 6 Garrett Casto 2012-10-08 15:33:45 PDT 
Created attachment 167632 [details]
Patch
Comment 7 Garrett Casto 2012-10-08 15:42:10 PDT 
So I just realized that this hasn't been submitted. The new patch has updated ChangeLog files, but everything else should be unchanged. Kent-san, would you mind sending this through the commit queue after review?
Comment 8 Kent Tamura 2012-10-09 06:37:33 PDT 
Comment on attachment 167632 [details]
Patch

You needed to set "commit-queue ?" flag to ask to commit the patch.
Comment 9 WebKit Review Bot 2012-10-09 06:43:09 PDT 
Comment on attachment 167632 [details]
Patch

Clearing flags on attachment: 167632

Committed r130756: <http://trac.webkit.org/changeset/130756>
Comment 10 WebKit Review Bot 2012-10-09 06:43:13 PDT 
All reviewed patches have been landed.  Closing bug.