WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93648
[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
https://bugs.webkit.org/show_bug.cgi?id=93648
Summary
[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
Pierre Rossi
Reported
2012-08-09 13:29:42 PDT
[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
Attachments
Patch
(3.95 KB, patch)
2012-08-09 13:42 PDT
,
Pierre Rossi
no flags
Details
Formatted Diff
Diff
Patch
(6.49 KB, patch)
2012-08-10 08:28 PDT
,
Pierre Rossi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pierre Rossi
Comment 1
2012-08-09 13:42:27 PDT
Created
attachment 157533
[details]
Patch
Simon Hausmann
Comment 2
2012-08-09 22:20:59 PDT
Comment on
attachment 157533
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=157533&action=review
> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:388 > +void FrameLoaderClientQt::dispatchDidNavigateWithinPage() > +{ > + if (!m_webFrame) > + return; > + > + FrameLoader* loader = m_frame->loader(); > + bool loaderCompleted = !(loader->activeDocumentLoader() && loader->activeDocumentLoader()->isLoadingInAPISense()); > + > + if (!loaderCompleted) > + return; > + > + dispatchDidCommitLoad(); > + dispatchDidFinishLoad(); > +}
If this is all cross-platform, would it make sense to have this in the base class? Just wondering. How is it done in WK2?
Pierre Rossi
Comment 3
2012-08-10 08:28:42 PDT
Created
attachment 157735
[details]
Patch
Kenneth Rohde Christiansen
Comment 4
2012-08-10 08:59:32 PDT
Comment on
attachment 157735
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=157735&action=review
> Source/WebKit/qt/ChangeLog:8 > + Add support for push/replace/pop by implementing dispatchDidNavigateWithinPage.
Basically all you are doing it to make sure the urlChanged signal is fired etc, all the history() methods already have the right state.
WebKit Review Bot
Comment 5
2012-08-11 06:26:43 PDT
Comment on
attachment 157735
[details]
Patch Clearing flags on attachment: 157735 Committed
r125352
: <
http://trac.webkit.org/changeset/125352
>
WebKit Review Bot
Comment 6
2012-08-11 06:26:47 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug