Bug 93648 – [Qt] Add support for HTML5 state object history API in FrameLoaderClientQt

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pierre Rossi]

[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt

[Pierre Rossi]

Created attachment 157533 [details]
Patch

[Simon Hausmann]

Comment on attachment 157533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157533&action=review

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:388
> +void FrameLoaderClientQt::dispatchDidNavigateWithinPage()
> +{
> +    if (!m_webFrame)
> +        return;
> +
> +    FrameLoader* loader = m_frame->loader();
> +    bool loaderCompleted = !(loader->activeDocumentLoader() && loader->activeDocumentLoader()->isLoadingInAPISense());
> +
> +    if (!loaderCompleted)
> +        return;
> +
> +    dispatchDidCommitLoad();
> +    dispatchDidFinishLoad();
> +}

If this is all cross-platform, would it make sense to have this in the base class? Just wondering. How is it done in WK2?

[Pierre Rossi]

Created attachment 157735 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 157735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157735&action=review

> Source/WebKit/qt/ChangeLog:8
> +        Add support for push/replace/pop by implementing dispatchDidNavigateWithinPage.

Basically all you are doing it to make sure the urlChanged signal is fired etc, all the history() methods already have the right state.

[WebKit Review Bot]

Comment on attachment 157735 [details]
Patch

Clearing flags on attachment: 157735

Committed r125352: <http://trac.webkit.org/changeset/125352>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.