Bug 93644 – [BlackBerry] Introduce a JavaScript Variant object

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Benjamin Meyer]

The JavaScriptVariant can be used for functions that return results from
JavaScript such as executeJavaScript or functions that take arguments
to pass a variable to JavaScript and they want to make sure the type
is correct.

[Benjamin Meyer]

Created attachment 157524 [details]
patch

[WebKit Review Bot]

Attachment 157524 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.h:24:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Meyer]

Created attachment 157529 [details]
patch

Fixed style error

[Adam Treat]

Comment on attachment 157529 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157529&action=review

I think this looks good overall.  Please fix the issues and then I'll look one last time.

> Source/WebKit/blackberry/Api/JavaScriptVariant.cpp:87
> +        // Output warning?

ASSERT_NOT_REACHED() I would say.

> Source/WebKit/blackberry/Api/JavaScriptVariant.h:29
> +

Remove the extra new line here.

[Benjamin Meyer]

Created attachment 157551 [details]
patch

Corrections from Adam's review

[Antonio Gomes]

Comment on attachment 157551 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157551&action=review

> Source/WebKit/blackberry/Api/JavaScriptVariant.h:31
> +class BLACKBERRY_EXPORT JavaScriptVariant {
> +
> +public:

nit: extra blank line.

> Source/WebKit/blackberry/ChangeLog:16
> +        Reviewed by Joe Mason

Should be "Internally reviewed by Joe"

[Benjamin Meyer]

Created attachment 157771 [details]
patch

Changes from Antonio Gomes comments, (remove blank link and change review by link in the changelogs and commit message)

[WebKit Review Bot]

Comment on attachment 157771 [details]
patch

Clearing flags on attachment: 157771

Committed r125324: <http://trac.webkit.org/changeset/125324>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.