RESOLVED FIXED93630
[chromium] Remove scissor from the namings in CCOcclusionTracker 
https://bugs.webkit.org/show_bug.cgi?id=93630
Summary [chromium] Remove scissor from the namings in CCOcclusionTracker
Dana Jansens
Reported 2012-08-09 10:49:07 PDT
[chromium] Remove scissor from the namings in CCOcclusionTracker
Attachments
Patch (73.64 KB, patch)
2012-08-09 10:51 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
for-ews (73.65 KB, patch)
2012-08-09 13:20 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
for-ews (73.60 KB, patch)
2012-08-09 14:34 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-08-09 10:51:41 PDT
Created attachment 157489 [details] Patch
Adrienne Walker
Comment 2 2012-08-09 11:27:43 PDT
Comment on attachment 157489 [details] Patch R=me. Thanks for splitting out the rename. It's so much easier to review.
WebKit Review Bot
Comment 3 2012-08-09 11:50:14 PDT
Comment on attachment 157489 [details] Patch Attachment 157489 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13459651
Dana Jansens
Comment 4 2012-08-09 13:20:51 PDT
Created attachment 157526 [details] for-ews
WebKit Review Bot
Comment 5 2012-08-09 13:48:27 PDT
Comment on attachment 157526 [details] for-ews Attachment 157526 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13457948
Dana Jansens
Comment 6 2012-08-09 14:34:37 PDT
Created attachment 157553 [details] for-ews
Dana Jansens
Comment 7 2012-08-09 14:35:18 PDT
This is really strange: Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:633: error: 'class<unnamed>::TestCCOcclusionTrackerWithClip<WebCore::LayerChromium, WebCore::RenderSurfaceChromium>' has no member named 'useDefaultLayerScissorRect' This patch is changing these lines, but they are still there somehow when it tries to compile. Giving EWS another shot at this.. Clearly it all compiles locally.
WebKit Review Bot
Comment 8 2012-08-10 08:29:18 PDT
Comment on attachment 157553 [details] for-ews Clearing flags on attachment: 157553 Committed r125282: <http://trac.webkit.org/changeset/125282>
WebKit Review Bot
Comment 9 2012-08-10 08:29:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.