Bug 93630 - [chromium] Remove scissor from the namings in CCOcclusionTracker
Summary: [chromium] Remove scissor from the namings in CCOcclusionTracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 91800
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-09 10:49 PDT by Dana Jansens
Modified: 2012-08-10 08:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (73.64 KB, patch)
2012-08-09 10:51 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
for-ews (73.65 KB, patch)
2012-08-09 13:20 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
for-ews (73.60 KB, patch)
2012-08-09 14:34 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-08-09 10:49:07 PDT
[chromium] Remove scissor from the namings in CCOcclusionTracker
Comment 1 Dana Jansens 2012-08-09 10:51:41 PDT
Created attachment 157489 [details]
Patch
Comment 2 Adrienne Walker 2012-08-09 11:27:43 PDT
Comment on attachment 157489 [details]
Patch

R=me. Thanks for splitting out the rename.  It's so much easier to review.
Comment 3 WebKit Review Bot 2012-08-09 11:50:14 PDT
Comment on attachment 157489 [details]
Patch

Attachment 157489 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13459651
Comment 4 Dana Jansens 2012-08-09 13:20:51 PDT
Created attachment 157526 [details]
for-ews
Comment 5 WebKit Review Bot 2012-08-09 13:48:27 PDT
Comment on attachment 157526 [details]
for-ews

Attachment 157526 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13457948
Comment 6 Dana Jansens 2012-08-09 14:34:37 PDT
Created attachment 157553 [details]
for-ews
Comment 7 Dana Jansens 2012-08-09 14:35:18 PDT
This is really strange:

Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:633: error: 'class<unnamed>::TestCCOcclusionTrackerWithClip<WebCore::LayerChromium, WebCore::RenderSurfaceChromium>' has no member named 'useDefaultLayerScissorRect'

This patch is changing these lines, but they are still there somehow when it tries to compile. Giving EWS another shot at this.. Clearly it all compiles locally.
Comment 8 WebKit Review Bot 2012-08-10 08:29:18 PDT
Comment on attachment 157553 [details]
for-ews

Clearing flags on attachment: 157553

Committed r125282: <http://trac.webkit.org/changeset/125282>
Comment 9 WebKit Review Bot 2012-08-10 08:29:22 PDT
All reviewed patches have been landed.  Closing bug.