Bug 93614 - [BlackBerry] Get rid of glCopyTexImage2D in Cavas and WebGL code paths
Summary: [BlackBerry] Get rid of glCopyTexImage2D in Cavas and WebGL code paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 05:50 PDT by Arvid Nilsson
Modified: 2012-08-14 07:34 PDT (History)
14 users (show)

See Also:

Attachments
Patch (50.81 KB, patch)
2012-08-10 10:02 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (51.57 KB, patch)
2012-08-12 15:41 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (51.65 KB, patch)
2012-08-14 06:28 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-08-09 05:50:13 PDT 
PR 188472
Comment 1 Arvid Nilsson 2012-08-10 10:02:03 PDT 
Created attachment 157753 [details]
Patch
Comment 2 George Staikos 2012-08-10 17:39:38 PDT 
Comment on attachment 157753 [details]
Patch

you need to rebase this.
Comment 3 Arvid Nilsson 2012-08-11 02:32:16 PDT 
Hmm, it's rebased to most recent in our forked repo...
Comment 4 Arvid Nilsson 2012-08-12 15:40:01 PDT 
Aha, the merge conflict is because we haven't upstreamed the fix for https://bugs.webkit.org/show_bug.cgi?id=86483 (PR #153047) yet
Comment 5 Arvid Nilsson 2012-08-12 15:41:18 PDT 
Created attachment 157912 [details]
Patch
Comment 6 Arvid Nilsson 2012-08-12 15:41:42 PDT 
(In reply to comment #2)
> (From update of attachment 157753 [details])
> you need to rebase this.

Here's a patch that does apply to upstream
Comment 7 Antonio Gomes 2012-08-13 12:53:22 PDT 
Comment on attachment 157912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157912&action=review

> Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:96
> +    // If the image is still with us, it was never destroyed by the EGLImageLayerWebKitThread

lacks a "."

> Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:97
> +    if (m_image) {

early return preferable
Comment 8 Arvid Nilsson 2012-08-14 06:00:54 PDT 
(In reply to comment #7)
> (From update of attachment 157912 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157912&action=review
> 
> > Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:96
> > +    // If the image is still with us, it was never destroyed by the EGLImageLayerWebKitThread
> 
> lacks a "."
> 
> > Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:97
> > +    if (m_image) {
> 
> early return preferable

Will fix!
Comment 9 Arvid Nilsson 2012-08-14 06:28:37 PDT 
Created attachment 158314 [details]
Patch
Comment 10 Arvid Nilsson 2012-08-14 06:31:12 PDT 
Comment on attachment 158314 [details]
Patch

This patch is changed only to adress Antonio's review comments, so I'm just gonna cq+ it.
Comment 11 WebKit Review Bot 2012-08-14 07:34:00 PDT 
Comment on attachment 158314 [details]
Patch

Clearing flags on attachment: 158314

Committed r125563: <http://trac.webkit.org/changeset/125563>
Comment 12 WebKit Review Bot 2012-08-14 07:34:06 PDT 
All reviewed patches have been landed.  Closing bug.