Bug 93609 – Rename functions in the ARM port of DFG-JIT for better code readability.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gabor Ballabas]

Rename functions in the ARM port of DFG-JIT for better code readability. Also for better following of WebKit coding style.

[Gabor Ballabas]

Created attachment 157450 [details]
Patch

[Gabor Ballabas]

Created attachment 157718 [details]
Add a couple of function renaming to the previous patch.

[Gabor Ballabas]

Created attachment 157738 [details]
Final patch

[Filip Pizlo]

Comment on attachment 157738 [details]
Final patch

It's worth noting that for the assembler backends, we typically use underscore naming.  I'm fine with this patch, but I think maybe Zoltan would be a better judge of whether you want to change naming in this way.

[Filip Pizlo]

Zoltan, r=me if you're fine with this.

[Zoltan Herczeg]

Comment on attachment 157738 [details]
Final patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157738&action=review

> Source/JavaScriptCore/assembler/ARMAssembler.h:470
> -        void vsqrt_f64_r(int dd, int dm, Condition cc = AL)
> +        void vsqrtFloat64(int dd, int dm, Condition cc = AL)

Do not rename this, only remove the _r. There are other similar instances, probavbly a followup patch.

> Source/JavaScriptCore/assembler/ARMAssembler.h:475
> -        void vabs_f64_r(int dd, int dm, Condition cc = AL)
> +        void vabsFloat64(int dd, int dm, Condition cc = AL)

Ditto.

> Source/JavaScriptCore/assembler/ARMAssembler.h:480
> -        void vneg_f64_r(int dd, int dm, Condition cc = AL)
> +        void vnegFloat64(int dd, int dm, Condition cc = AL)

Ditto.

[Gabor Ballabas]

Created attachment 158278 [details]
Patch

[Gabor Ballabas]

(In reply to comment #6)
> (From update of attachment 157738 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157738&action=review
> 
> > Source/JavaScriptCore/assembler/ARMAssembler.h:470
> > -        void vsqrt_f64_r(int dd, int dm, Condition cc = AL)
> > +        void vsqrtFloat64(int dd, int dm, Condition cc = AL)
> 
> Do not rename this, only remove the _r. There are other similar instances, probavbly a followup patch.
> 
> > Source/JavaScriptCore/assembler/ARMAssembler.h:475
> > -        void vabs_f64_r(int dd, int dm, Condition cc = AL)
> > +        void vabsFloat64(int dd, int dm, Condition cc = AL)
> 
> Ditto.
> 
> > Source/JavaScriptCore/assembler/ARMAssembler.h:480
> > -        void vneg_f64_r(int dd, int dm, Condition cc = AL)
> > +        void vnegFloat64(int dd, int dm, Condition cc = AL)
> 
> Ditto.

Done.

[Zoltan Herczeg]

Comment on attachment 158278 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 158278 [details]
Patch

Clearing flags on attachment: 158278

Committed r125541: <http://trac.webkit.org/changeset/125541>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.