Bug 93609 - Rename functions in the ARM port of DFG-JIT for better code readability.
Summary: Rename functions in the ARM port of DFG-JIT for better code readability.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 05:21 PDT by Gabor Ballabas
Modified: 2012-08-14 04:28 PDT (History)
6 users (show)

See Also:


Attachments
Patch (58.74 KB, patch)
2012-08-09 05:34 PDT, Gabor Ballabas
no flags Details | Formatted Diff | Diff
Add a couple of function renaming to the previous patch. (64.78 KB, patch)
2012-08-10 05:52 PDT, Gabor Ballabas
no flags Details | Formatted Diff | Diff
Final patch (65.78 KB, patch)
2012-08-10 08:33 PDT, Gabor Ballabas
zherczeg: review-
zherczeg: commit-queue-
Details | Formatted Diff | Diff
Patch (65.70 KB, patch)
2012-08-14 03:29 PDT, Gabor Ballabas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Ballabas 2012-08-09 05:21:40 PDT
Rename functions in the ARM port of DFG-JIT for better code readability. Also for better following of WebKit coding style.
Comment 1 Gabor Ballabas 2012-08-09 05:34:04 PDT
Created attachment 157450 [details]
Patch
Comment 2 Gabor Ballabas 2012-08-10 05:52:35 PDT
Created attachment 157718 [details]
Add a couple of function renaming to the previous patch.
Comment 3 Gabor Ballabas 2012-08-10 08:33:06 PDT
Created attachment 157738 [details]
Final patch
Comment 4 Filip Pizlo 2012-08-13 15:50:11 PDT
Comment on attachment 157738 [details]
Final patch

It's worth noting that for the assembler backends, we typically use underscore naming.  I'm fine with this patch, but I think maybe Zoltan would be a better judge of whether you want to change naming in this way.
Comment 5 Filip Pizlo 2012-08-13 15:50:43 PDT
Zoltan, r=me if you're fine with this.
Comment 6 Zoltan Herczeg 2012-08-14 02:28:38 PDT
Comment on attachment 157738 [details]
Final patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157738&action=review

> Source/JavaScriptCore/assembler/ARMAssembler.h:470
> -        void vsqrt_f64_r(int dd, int dm, Condition cc = AL)
> +        void vsqrtFloat64(int dd, int dm, Condition cc = AL)

Do not rename this, only remove the _r. There are other similar instances, probavbly a followup patch.

> Source/JavaScriptCore/assembler/ARMAssembler.h:475
> -        void vabs_f64_r(int dd, int dm, Condition cc = AL)
> +        void vabsFloat64(int dd, int dm, Condition cc = AL)

Ditto.

> Source/JavaScriptCore/assembler/ARMAssembler.h:480
> -        void vneg_f64_r(int dd, int dm, Condition cc = AL)
> +        void vnegFloat64(int dd, int dm, Condition cc = AL)

Ditto.
Comment 7 Gabor Ballabas 2012-08-14 03:29:46 PDT
Created attachment 158278 [details]
Patch
Comment 8 Gabor Ballabas 2012-08-14 03:30:41 PDT
(In reply to comment #6)
> (From update of attachment 157738 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157738&action=review
> 
> > Source/JavaScriptCore/assembler/ARMAssembler.h:470
> > -        void vsqrt_f64_r(int dd, int dm, Condition cc = AL)
> > +        void vsqrtFloat64(int dd, int dm, Condition cc = AL)
> 
> Do not rename this, only remove the _r. There are other similar instances, probavbly a followup patch.
> 
> > Source/JavaScriptCore/assembler/ARMAssembler.h:475
> > -        void vabs_f64_r(int dd, int dm, Condition cc = AL)
> > +        void vabsFloat64(int dd, int dm, Condition cc = AL)
> 
> Ditto.
> 
> > Source/JavaScriptCore/assembler/ARMAssembler.h:480
> > -        void vneg_f64_r(int dd, int dm, Condition cc = AL)
> > +        void vnegFloat64(int dd, int dm, Condition cc = AL)
> 
> Ditto.

Done.
Comment 9 Zoltan Herczeg 2012-08-14 03:39:37 PDT
Comment on attachment 158278 [details]
Patch

r=me
Comment 10 WebKit Review Bot 2012-08-14 04:28:41 PDT
Comment on attachment 158278 [details]
Patch

Clearing flags on attachment: 158278

Committed r125541: <http://trac.webkit.org/changeset/125541>
Comment 11 WebKit Review Bot 2012-08-14 04:28:45 PDT
All reviewed patches have been landed.  Closing bug.