Bug 93601 – [BlackBerry] Tap highlight flashes checkerboard after pinch zoom

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Arvid Nilsson]

Until we do a more comprehensive improvement in AC checkerboarding, I have a workaround for this specific problem.

PR 189895

[Arvid Nilsson]

Created attachment 157708 [details]
Patch

[Antonio Gomes]

Comment on attachment 157708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157708&action=review

I will r+ to sync up downstream and upstream, but please consider my comment as a follow-up, if you agree.

> Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp:165
> +    // This layer is typically small enough that we can afford to cache all tiles and never
> +    // risk checkerboarding.
> +    return true;

it can be big enough: think of a <a><img/></a> on facebook. If zoomed in it easily takes the whole screen. Should we have a threshold?

[Arvid Nilsson]

(In reply to comment #2)
> (From update of attachment 157708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157708&action=review
> 
> I will r+ to sync up downstream and upstream, but please consider my comment as a follow-up, if you agree.
> 
> > Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp:165
> > +    // This layer is typically small enough that we can afford to cache all tiles and never
> > +    // risk checkerboarding.
> > +    return true;
> 
> it can be big enough: think of a <a><img/></a> on facebook. If zoomed in it easily takes the whole screen. Should we have a threshold?

Taking up the whole screen is not so bad, the inspector highlight was taking up the whole content size. But it is possible to design a web pag that has a huuge link so we get a highlight that takes up the whole content size. So we need to do something eventually.

[WebKit Review Bot]

Comment on attachment 157708 [details]
Patch

Clearing flags on attachment: 157708

Committed r125382: <http://trac.webkit.org/changeset/125382>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.