Bug 93579 - Fix null pointer deref in RenderFileUploadControl::computePreferredLogicalWidth().
Summary: Fix null pointer deref in RenderFileUploadControl::computePreferredLogicalWid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 22:53 PDT by Luke Macpherson
Modified: 2012-08-09 20:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2012-08-08 22:56 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (3.77 KB, patch)
2012-08-09 17:52 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (3.81 KB, patch)
2012-08-09 18:28 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-08-08 22:53:39 PDT 
Fix null pointer deref in RenderFileUploadControl::computePreferredLogicalWidth().
Comment 1 Luke Macpherson 2012-08-08 22:56:05 PDT 
Created attachment 157390 [details]
Patch
Comment 2 Kent Tamura 2012-08-08 23:40:58 PDT 
Comment on attachment 157390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157390&action=review

> Source/WebCore/ChangeLog:10
> +        Test: fast/css/upload-control-crash.html

I think this is not in the CSS area.  It should be fast/forms/file/file-crash-by-display-none-button.html or something.
Comment 3 Luke Macpherson 2012-08-09 17:52:21 PDT 
Created attachment 157596 [details]
Patch for landing
Comment 4 Kent Tamura 2012-08-09 17:53:20 PDT 
Comment on attachment 157596 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=157596&action=review

> Source/WebCore/ChangeLog:10
> +        Test: fast/forms/file-crash-by-display-none-button.html

Please put it to fast/forms/file/, not fast/forms/.
Comment 5 Luke Macpherson 2012-08-09 18:28:57 PDT 
Created attachment 157605 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-08-09 20:37:20 PDT 
Comment on attachment 157605 [details]
Patch for landing

Clearing flags on attachment: 157605

Committed r125243: <http://trac.webkit.org/changeset/125243>
Comment 7 WebKit Review Bot 2012-08-09 20:37:24 PDT 
All reviewed patches have been landed.  Closing bug.