Bug 93576 – Web Inspector: Add title attribute to Resources:Frames

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Rob Colburn]

On the Resources Panel, you can hover over resources Images and Scripts resources to see their full URL.  However, this is not true of the Frames themselves which appear as folders.

[sam]

Created attachment 158203 [details]
Patch

[sam]

Created attachment 158205 [details]
snapshot showing mock tooltip.

[Pavel Feldman]

Comment on attachment 158203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158203&action=review

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1064
> +        this.tooltip = frame.name + " (" + frame.url + ")";

You should move this line into the frameNavigated: above. Same place title gets updated. Frame will get new url upon navigation.

[sam]

Created attachment 158219 [details]
Patch

[sam]

Comment on attachment 158219 [details]
Patch

Hi Pavel, Can you please grant cq+, forgot to add it. Thank you.

[WebKit Review Bot]

Comment on attachment 158219 [details]
Patch

Rejecting attachment 158219 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 158219 [details]
Patch

Rejecting attachment 158219 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [NRWT] Compare results between different platforms

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13488565

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.