Bug 93576 - Web Inspector: Add title attribute to Resources:Frames
Summary: Web Inspector: Add title attribute to Resources:Frames
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: sam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 21:23 PDT by Rob Colburn
Modified: 2014-12-12 14:37 PST (History)
11 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2012-08-13 21:30 PDT, sam
no flags Details | Formatted Diff | Diff
snapshot showing mock tooltip. (36.56 KB, image/png)
2012-08-13 21:31 PDT, sam
no flags Details
Patch (1.31 KB, patch)
2012-08-13 22:45 PDT, sam
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Colburn 2012-08-08 21:23:38 PDT
On the Resources Panel, you can hover over resources Images and Scripts resources to see their full URL.  However, this is not true of the Frames themselves which appear as folders.
Comment 1 sam 2012-08-13 21:30:59 PDT
Created attachment 158203 [details]
Patch
Comment 2 sam 2012-08-13 21:31:57 PDT
Created attachment 158205 [details]
snapshot showing mock tooltip.
Comment 3 Pavel Feldman 2012-08-13 22:17:10 PDT
Comment on attachment 158203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158203&action=review

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1064
> +        this.tooltip = frame.name + " (" + frame.url + ")";

You should move this line into the frameNavigated: above. Same place title gets updated. Frame will get new url upon navigation.
Comment 4 sam 2012-08-13 22:45:26 PDT
Created attachment 158219 [details]
Patch
Comment 5 sam 2012-08-13 22:59:18 PDT
Comment on attachment 158219 [details]
Patch

Hi Pavel, Can you please grant cq+, forgot to add it. Thank you.
Comment 6 WebKit Review Bot 2012-08-13 22:59:34 PDT
Comment on attachment 158219 [details]
Patch

Rejecting attachment 158219 [details] from commit-queue.

dsam2912@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 WebKit Review Bot 2012-08-14 01:59:11 PDT
Comment on attachment 158219 [details]
Patch

Rejecting attachment 158219 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [NRWT] Compare results between different platforms

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13488565
Comment 8 Brian Burg 2014-12-12 14:37:03 PST
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.