WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93571
Move some CSS -webkit-locale tests out of fast/text/
https://bugs.webkit.org/show_bug.cgi?id=93571
Summary
Move some CSS -webkit-locale tests out of fast/text/
Matt Falkenhagen
Reported
2012-08-08 19:37:16 PDT
As per ap's
comment #9
on
bug 77724
, the http-equiv content-language tests don't belong under fast/text/. Since they are testing the CSS property -webkit-locale, I think they make sense under fast/css/.
Attachments
Patch
(61.44 KB, patch)
2012-08-08 20:09 PDT
,
Matt Falkenhagen
no flags
Details
Formatted Diff
Diff
Patch
(81.83 KB, patch)
2012-08-09 21:27 PDT
,
Matt Falkenhagen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1
2012-08-08 20:09:57 PDT
Created
attachment 157375
[details]
Patch
Alexey Proskuryakov
Comment 2
2012-08-09 09:30:56 PDT
Comment on
attachment 157375
[details]
Patch Is it intentional that you didn't move fast/text/international ones? I'm not sure if they need to be moved. If you decide to move these as well, please update LayoutTests/platform/qt-mac/Skipped, which skips some.
Matt Falkenhagen
Comment 3
2012-08-09 21:07:48 PDT
I think the fast/text/international ones are OK since they test font selection for text instead of just CSS property values. But maybe they belong better in some place like fonts/? I found some more tests that should be moved, though. I'll add them to the patch.
Matt Falkenhagen
Comment 4
2012-08-09 21:27:07 PDT
Created
attachment 157632
[details]
Patch
WebKit Review Bot
Comment 5
2012-08-09 23:35:10 PDT
Comment on
attachment 157632
[details]
Patch Clearing flags on attachment: 157632 Committed
r125254
: <
http://trac.webkit.org/changeset/125254
>
WebKit Review Bot
Comment 6
2012-08-09 23:35:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug