Bug 93571 - Move some CSS -webkit-locale tests out of fast/text/
Summary: Move some CSS -webkit-locale tests out of fast/text/
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Falkenhagen
Depends on:
Blocks: 77724
  Show dependency treegraph
Reported: 2012-08-08 19:37 PDT by Matt Falkenhagen
Modified: 2012-08-09 23:35 PDT (History)
2 users (show)

See Also:

Patch (61.44 KB, patch)
2012-08-08 20:09 PDT, Matt Falkenhagen
no flags Details | Formatted Diff | Diff
Patch (81.83 KB, patch)
2012-08-09 21:27 PDT, Matt Falkenhagen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Falkenhagen 2012-08-08 19:37:16 PDT
As per ap's comment #9 on bug 77724, the http-equiv content-language tests don't belong under fast/text/.

Since they are testing the CSS property -webkit-locale, I think they make sense under fast/css/.
Comment 1 Matt Falkenhagen 2012-08-08 20:09:57 PDT
Created attachment 157375 [details]
Comment 2 Alexey Proskuryakov 2012-08-09 09:30:56 PDT
Comment on attachment 157375 [details]

Is it intentional that you didn't move fast/text/international ones? I'm not sure if they need to be moved.

If you decide to move these as well, please update LayoutTests/platform/qt-mac/Skipped, which skips some.
Comment 3 Matt Falkenhagen 2012-08-09 21:07:48 PDT
I think the fast/text/international ones are OK since they test font selection for text instead of just CSS property values. But maybe they belong better in some place like fonts/?

I found some more tests that should be moved, though. I'll add them to the patch.
Comment 4 Matt Falkenhagen 2012-08-09 21:27:07 PDT
Created attachment 157632 [details]
Comment 5 WebKit Review Bot 2012-08-09 23:35:10 PDT
Comment on attachment 157632 [details]

Clearing flags on attachment: 157632

Committed r125254: <http://trac.webkit.org/changeset/125254>
Comment 6 WebKit Review Bot 2012-08-09 23:35:13 PDT
All reviewed patches have been landed.  Closing bug.