Bug 93562 - Parsing "all" for -webkit-user-select
Summary: Parsing "all" for -webkit-user-select
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 91912
  Show dependency tree / graph
 
Reported: 2012-08-08 17:49 PDT by Alice Cheng
Modified: 2012-08-10 21:53 PDT (History)
9 users (show)

See Also:

Attachments
patch (6.42 KB, patch)
2012-08-08 17:52 PDT, Alice Cheng 		no flags Details | Formatted Diff | Diff
patch (6.44 KB, patch)
2012-08-08 18:13 PDT, Alice Cheng 		no flags Details | Formatted Diff | Diff
patch for buildbot (8.15 KB, patch)
2012-08-10 09:18 PDT, Alice Cheng 		no flags Details | Formatted Diff | Diff
Patch for style bot (8.15 KB, patch)
2012-08-10 12:21 PDT, Alice Cheng 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Cheng 2012-08-08 17:49:58 PDT 
This is the first part for https://bugs.webkit.org/show_bug.cgi?id=91912

Parse the new "all" value for -webkit-user-select
Comment 1 Alice Cheng 2012-08-08 17:52:10 PDT 
Created attachment 157353 [details]
patch

This patch correctly parses the new value "all" for -webkit-user-select
Comment 2 Alice Cheng 2012-08-08 18:13:12 PDT 
Created attachment 157356 [details]
patch

Previous patch was malformed. Sorry about it.
Comment 3 Alice Cheng 2012-08-10 09:18:07 PDT 
Created attachment 157744 [details]
patch for buildbot

modified the ambiguous enum in gtk/webkitwebview.cpp
Comment 4 WebKit Review Bot 2012-08-10 09:20:22 PDT 
Attachment 157744 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1
Source/WebCore/rendering/style/StyleRareInheritedData.h:92:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alice Cheng 2012-08-10 12:21:57 PDT 
Created attachment 157786 [details]
Patch for style bot

fixed the style
Comment 6 WebKit Review Bot 2012-08-10 14:48:19 PDT 
Comment on attachment 157786 [details]
Patch for style bot

Clearing flags on attachment: 157786

Committed r125330: <http://trac.webkit.org/changeset/125330>
Comment 7 WebKit Review Bot 2012-08-10 14:48:25 PDT 
All reviewed patches have been landed.  Closing bug.