Bug 93537 – update bot parsing of new-run-webkit-tests' output

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

update bot parsing of new-run-webkit-tests' output

[Dirk Pranke]

Created attachment 157312 [details]
Patch

[Dirk Pranke]

Ossy, does this look good to you? If so, can you land it (or cq+ it) and update your bots as well and let me know when I can re-land the output changes? Thanks!

[Ryosuke Niwa]

Comment on attachment 157312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157312&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:352
> -            ('flakes', re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)')),
> +            ('flakes', re.compile(r'[Uu]nexpected flakiness.+:?\s*\((\d+)\)')),

Why don't we just ignore cases?

[Ryosuke Niwa]

Comment on attachment 157312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157312&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:355
> +            ('missing results', re.compile(r'(no expected results found|missing results)\s*:\s+\((\d+)\)')),
> +            ('failures', re.compile(r'Regressions: [Uu]nexpected.+:?\s*\((\d+)\)')),

Ditto.

[Dirk Pranke]

Comment on attachment 157312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157312&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:355
>> +            ('failures', re.compile(r'Regressions: [Uu]nexpected.+:?\s*\((\d+)\)')),
> 
> Ditto.

we could, but I'll leave things tight for now. ideally we'd just get a block of json to read and not do this hand-parsing.

[Csaba Osztrogonác]

Comment on attachment 157312 [details]
Patch

Clearing flags on attachment: 157312

Committed r125153: <http://trac.webkit.org/changeset/125153>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

It seems automatic master restart still doesn't work. :(
Bill or Lucas, could you restart/reconfigure the master, please?

[Csaba Osztrogonác]

Reopen until master restart. Lucas, please close it after restarting the master. Thanks in advance.

[Lucas Forschler]

Sorry for the delay.  I've manually updated the master and restarted it.  Please verify that things are working as expected and let me know.