Bug 93532 - Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors
Summary: Make isTransparentSilverlightBackgroundValue handle all the possible transpar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 14:56 PDT by Anders Carlsson
Modified: 2012-08-08 17:25 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.66 KB, patch)
2012-08-08 15:01 PDT, Anders Carlsson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-08-08 14:56:32 PDT
Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors
Comment 1 Anders Carlsson 2012-08-08 15:01:34 PDT
Created attachment 157305 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-08-08 15:07:21 PDT
Comment on attachment 157305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157305&action=review

> Source/WebKit2/ChangeLog:6
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

oops

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:-554
> -    // FIXME: We should handle all the cases from http://msdn.microsoft.com/en-us/library/cc838148(VS.95).aspx here

I'd like this url to remain in the comment so I can see where this crazy "ScRGB" stuff comes from.
Comment 3 Anders Carlsson 2012-08-08 15:12:50 PDT
Committed r125098: <http://trac.webkit.org/changeset/125098>
Comment 4 Darin Adler 2012-08-08 17:25:03 PDT
Patch that was landed has a comment with the word "forumat" in it.