Bug 93530 - css3/flexbox/content-height-with-scrollbars.html failing image test on Lion and MountainLion
Summary: css3/flexbox/content-height-with-scrollbars.html failing image test on Lion a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2012-08-08 14:49 PDT by Dean Jackson
Modified: 2012-08-08 19:23 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2012-08-08 14:49:24 PDT
css3/flexbox/content-height-with-scrollbars.html from https://bugs.webkit.org/show_bug.cgi?id=92667 is failing image comparison (just!) on Lion and Mountain Lion.
Comment 1 Dean Jackson 2012-08-08 14:54:45 PDT
Expectations in http://trac.webkit.org/changeset/125093
Comment 2 Ojan Vafai 2012-08-08 15:00:44 PDT
Looks like it's failing on GTK as well: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=css3%2Fflexbox%2Fcontent-height-with-scrollbars.html.

Looks like a rounding error. I would guess that this works in Chromium because we have sub-pixel layout enabled. Although, that doesn't explain why it's not failing for Qt/Efl.
Comment 3 Tony Chang 2012-08-08 16:27:10 PDT
(In reply to comment #2)
> Looks like it's failing on GTK as well: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=css3%2Fflexbox%2Fcontent-height-with-scrollbars.html.
> 
> Looks like a rounding error. I would guess that this works in Chromium because we have sub-pixel layout enabled. Although, that doesn't explain why it's not failing for Qt/Efl.

Maybe Qt and Efl have scrollbars that are an even number of pixels, allowing the rounding to work?

I'll see if I can change the test so it'll work on all platforms.
Comment 4 Tony Chang 2012-08-08 19:23:58 PDT
Fixed the test in http://trac.webkit.org/changeset/125140 .