Bug 93526 - Avoid backing store on layers created for CoreAnimation plugins
Summary: Avoid backing store on layers created for CoreAnimation plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-08-08 14:29 PDT by Simon Fraser (smfr)
Modified: 2012-08-08 17:38 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.76 KB, patch)
2012-08-08 14:31 PDT, Simon Fraser (smfr)
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-08-08 14:29:06 PDT
Avoid backing store on layers created for CoreAnimation plugins
Comment 1 Simon Fraser (smfr) 2012-08-08 14:31:36 PDT
Created attachment 157299 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-08-08 14:32:26 PDT
<rdar://problem/12052828>
Comment 3 Dean Jackson 2012-08-08 15:02:03 PDT
Comment on attachment 157299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157299&action=review

> Source/WebCore/ChangeLog:8
> +        We create a compositing layer for <emebed> objects whose plug-in supports

typo emembedebed
Comment 4 Simon Fraser (smfr) 2012-08-08 15:17:57 PDT
http://trac.webkit.org/changeset/125101
Comment 5 Andrew Scherkus 2012-08-08 15:28:37 PDT
Committed r125102: <http://trac.webkit.org/changeset/125102>
Comment 6 Darin Adler 2012-08-08 17:25:36 PDT
Comment on attachment 157299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157299&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:913
> +    if (renderObject->isReplaced() && !isCompositedPlugin(renderObject))
> +            return false;

Wrong indentation on this return statement.