Bug 93520 - Web Inspector: Refactor InspectorTest to split evals for initialization from runTest
Summary: Web Inspector: Refactor InspectorTest to split evals for initialization from ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 14:12 PDT by johnjbarton
Modified: 2012-08-17 13:11 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.79 KB, patch)
2012-08-08 14:22 PDT, johnjbarton
no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2012-08-16 17:06 PDT, johnjbarton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2012-08-08 14:12:46 PDT
Currently inspector-test.js function runTest concatenates a long initialization function sequence with the test code from the web page. By splitting these two in to two different eval() with different names it will be much easier to debug the test code (which is the goal of bug 92429).
Comment 1 johnjbarton 2012-08-08 14:22:30 PDT
Created attachment 157292 [details]
Patch
Comment 2 johnjbarton 2012-08-16 17:06:11 PDT
Created attachment 158952 [details]
Patch
Comment 3 WebKit Review Bot 2012-08-17 13:10:55 PDT
Comment on attachment 158952 [details]
Patch

Clearing flags on attachment: 158952

Committed r125927: <http://trac.webkit.org/changeset/125927>
Comment 4 WebKit Review Bot 2012-08-17 13:11:20 PDT
All reviewed patches have been landed.  Closing bug.