Bug 93517 - Horizontal scrollbar appears in the month-year selector of input[type=date]
Summary: Horizontal scrollbar appears in the month-year selector of input[type=date]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kevin Ellis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 13:54 PDT by Kevin Ellis
Modified: 2012-08-10 09:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.66 KB, patch)
2012-08-08 14:11 PDT, Kevin Ellis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ellis 2012-08-08 13:54:44 PDT
Horizontal scrollbar appears in the month-year selector of input[type=date]
Comment 1 Kevin Ellis 2012-08-08 14:11:19 PDT
Created attachment 157289 [details]
Patch
Comment 2 Kevin Ellis 2012-08-08 14:16:45 PDT
Horizontal scrollbar reported on Chrome with a Japanese UI on Windows 7.
Comment 3 Kent Tamura 2012-08-08 18:22:34 PDT
Comment on attachment 157289 [details]
Patch

LGTM.

FYI: WebCore/Resources/colorSuggestionPicker.js has a code to get the scrollbar width. We had better share some code with it.
Comment 4 Kevin Ellis 2012-08-09 11:07:42 PDT
Several other functions could be shared between colorSuggestionPicker.js and calendarPicker.js as well such as $() bind() and createElement().  OK with a separate patch to consolidate the common utility functions into a separate js file?
Comment 5 Kent Tamura 2012-08-09 16:33:07 PDT
>  OK with a separate patch to consolidate the common utility functions into a separate js file?

Yes.  It's not your responsibility.  The patch in this bug is ok as is.
Comment 6 WebKit Review Bot 2012-08-10 09:16:15 PDT
Comment on attachment 157289 [details]
Patch

Clearing flags on attachment: 157289

Committed r125289: <http://trac.webkit.org/changeset/125289>
Comment 7 WebKit Review Bot 2012-08-10 09:16:19 PDT
All reviewed patches have been landed.  Closing bug.