Bug 93515 – LayoutTest: css3/calc/transitions-dependent.html causes css3/calc/transitions.html to fail

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Roger Fong]

The transitions-dependent.html test was causing the transitions.html test to fail.
This was a result of a timeout callback set in the first test that was only being fired in the second test. 
The first test did not use waitUntilDone/notifyDone. 
The second test printed out an extra TypeError: 'undefined' error message because the callback was defined in the first test and was thus 'undefined' by the time it was called while the second test was running.
        
In addition, the test contained the following line:

     window.addEventListener("load", function() { waitForAnimationStart(runTest(expectedValues)); }, false);

which does not work as intended because the parameter to waitForAnimationStart should have been a function that calls runTest, not the call to the runTest function itself, which calls the method immediately.

[Roger Fong]

Created attachment 157285 [details]
patch

[Roger Fong]

Hi Mike, I believe you originally wrote the test

[Roger Fong]

Can I get you to review it? 
Thanks

[Mike Lawther]

Comment on attachment 157285 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157285&action=review

Nice - thanks for this Roger!

I'll watch http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Ftrans after this lands and once it's verified green we can remove the expectations set in http://trac.webkit.org/changeset/121506 and resolve https://bugs.webkit.org/show_bug.cgi?id=90234 as well, as I thought there was a problem in the transition test framework.

The patch looks good to me, but as I'm not a reviewer, we'll need a reviewer to r+ this.

> LayoutTests/css3/calc/transitions-dependent.html:68
> +

nit: extra blank line

[Tim Horton]

Ok, with Mike's input I'll happily r+ if you undo the extra blank line :D

[Roger Fong]

Created attachment 157310 [details]
patch nit fix

Good to go,
Thanks

[Roger Fong]

Created attachment 157311 [details]
the actual fixed patch

[WebKit Review Bot]

Comment on attachment 157311 [details]
the actual fixed patch

Clearing flags on attachment: 157311

Committed r125111: <http://trac.webkit.org/changeset/125111>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.