Bug 93515 - LayoutTest: css3/calc/transitions-dependent.html causes css3/calc/transitions.html to fail
Summary: LayoutTest: css3/calc/transitions-dependent.html causes css3/calc/transitions...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Roger Fong
Keywords: LayoutTestFailure
Depends on:
Reported: 2012-08-08 13:47 PDT by Roger Fong
Modified: 2012-08-08 16:40 PDT (History)
4 users (show)

See Also:

patch (3.62 KB, patch)
2012-08-08 13:56 PDT, Roger Fong
thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff
patch nit fix (3.61 KB, patch)
2012-08-08 15:28 PDT, Roger Fong
no flags Details | Formatted Diff | Diff
the actual fixed patch (3.44 KB, patch)
2012-08-08 15:32 PDT, Roger Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2012-08-08 13:47:41 PDT
The transitions-dependent.html test was causing the transitions.html test to fail.
This was a result of a timeout callback set in the first test that was only being fired in the second test. 
The first test did not use waitUntilDone/notifyDone. 
The second test printed out an extra TypeError: 'undefined' error message because the callback was defined in the first test and was thus 'undefined' by the time it was called while the second test was running.
In addition, the test contained the following line:

     window.addEventListener("load", function() { waitForAnimationStart(runTest(expectedValues)); }, false);

which does not work as intended because the parameter to waitForAnimationStart should have been a function that calls runTest, not the call to the runTest function itself, which calls the method immediately.
Comment 1 Roger Fong 2012-08-08 13:56:30 PDT
Created attachment 157285 [details]
Comment 2 Roger Fong 2012-08-08 13:57:05 PDT
Hi Mike, I believe you originally wrote the test
Comment 3 Roger Fong 2012-08-08 13:57:20 PDT
Can I get you to review it? 
Comment 4 Mike Lawther 2012-08-08 14:41:47 PDT
Comment on attachment 157285 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=157285&action=review

Nice - thanks for this Roger!

I'll watch http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Ftrans after this lands and once it's verified green we can remove the expectations set in http://trac.webkit.org/changeset/121506 and resolve https://bugs.webkit.org/show_bug.cgi?id=90234 as well, as I thought there was a problem in the transition test framework.

The patch looks good to me, but as I'm not a reviewer, we'll need a reviewer to r+ this.

> LayoutTests/css3/calc/transitions-dependent.html:68
> +

nit: extra blank line
Comment 5 Tim Horton 2012-08-08 14:45:22 PDT
Ok, with Mike's input I'll happily r+ if you undo the extra blank line :D
Comment 6 Roger Fong 2012-08-08 15:28:21 PDT
Created attachment 157310 [details]
patch nit fix

Good to go,
Comment 7 Roger Fong 2012-08-08 15:32:22 PDT
Created attachment 157311 [details]
the actual fixed patch
Comment 8 WebKit Review Bot 2012-08-08 16:40:06 PDT
Comment on attachment 157311 [details]
the actual fixed patch

Clearing flags on attachment: 157311

Committed r125111: <http://trac.webkit.org/changeset/125111>
Comment 9 WebKit Review Bot 2012-08-08 16:40:09 PDT
All reviewed patches have been landed.  Closing bug.