Bug 93510 - Implement new synchronized audio I/O render method in chromium
Summary: Implement new synchronized audio I/O render method in chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 13:12 PDT by Chris Rogers
Modified: 2012-08-14 16:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.83 KB, patch)
2012-08-08 13:17 PDT, Chris Rogers 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-08-08 13:12:40 PDT 
Implement new synchronized audio I/O render method in chromium
Comment 1 Chris Rogers 2012-08-08 13:17:56 PDT 
Created attachment 157277 [details]
Patch
Comment 2 Kenneth Russell 2012-08-13 17:43:41 PDT 
Comment on attachment 157277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157277&action=review

Looks generally fine -- r=me -- but a couple of comments which you can feel free to ignore if they're off base.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:92
> +        AudioBus silence(2, renderBufferSize);

2? Really? Why not numberOfChannels?

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:139
> +        AudioBus wrapperBus(2, numberOfFrames, false);

2 again? If this is a temporary hack until this code is generalized then add a FIXME.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:180
> +    // Render using the Web Audio engine.

Does this comment add any value?
Comment 3 Chris Rogers 2012-08-14 16:17:25 PDT 
Committed r125618: <http://trac.webkit.org/changeset/125618>