Bug 93499 - Web Inspector: improve large array logging experience
Summary: Web Inspector: improve large array logging experience
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 11:04 PDT by Pavel Feldman
Modified: 2012-08-09 05:09 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.89 KB, patch)
2012-08-08 11:27 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-08 11:04:03 PDT 
Today, dumping array of 500 elements results in painful experience:
Array[500]
[0 … 24]
  [0 … 4]
    0: 0
    1: 1
    2: 2
    3: 3
    4: 4
  [5 … 9]
  [10 … 14]
  [15 … 19]
  [20 … 24]
[25 … 49]
[50 … 74]

This change converts it into:
Array[500]
    [0 … 99]
    [100 … 199]
    [200 … 299]
    [300 … 399]
    [400 … 499]

With 100 elements in each group (not more than 100 elements on one level).
Comment 1 Pavel Feldman 2012-08-08 11:27:10 PDT 
Created attachment 157259 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-08-09 01:45:47 PDT 
Comment on attachment 157259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157259&action=review

> LayoutTests/inspector/console/console-big-array.html:47
> +        populated = this._toIndex == 100;

=== ?
Comment 3 WebKit Review Bot 2012-08-09 05:09:12 PDT 
Comment on attachment 157259 [details]
Patch

Clearing flags on attachment: 157259

Committed r125165: <http://trac.webkit.org/changeset/125165>
Comment 4 WebKit Review Bot 2012-08-09 05:09:17 PDT 
All reviewed patches have been landed.  Closing bug.