WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
UNCONFIRMED
93481
Accelerated canvas elements shouldn't share style
https://bugs.webkit.org/show_bug.cgi?id=93481
Summary
Accelerated canvas elements shouldn't share style
Filip Spacek
Reported
2012-08-08 07:42:11 PDT
Created
attachment 157216
[details]
Don't share styles for accelerated canvases Style sharing causes style recalculation to short circuit which results in the canvas elements not getting their own layer when they become accelerated.
Attachments
Don't share styles for accelerated canvases
(1.19 KB, patch)
2012-08-08 07:42 PDT
,
Filip Spacek
no flags
Details
Formatted Diff
Diff
Don't share styles for accelerated canvases
(1.30 KB, patch)
2012-08-08 07:52 PDT
,
Filip Spacek
simon.fraser
: review-
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Don't share styles for accelerated canvases
(1.41 KB, patch)
2012-08-09 18:39 PDT
,
Filip Spacek
thorton
: review-
thorton
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2012-08-08 07:44:51 PDT
Attachment 157216
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Spacek
Comment 2
2012-08-08 07:52:54 PDT
Created
attachment 157217
[details]
Don't share styles for accelerated canvases Add bug number
George Staikos
Comment 3
2012-08-08 09:07:31 PDT
Comment on
attachment 157217
[details]
Don't share styles for accelerated canvases Need to set the r? flag if you want review...
George Staikos
Comment 4
2012-08-08 18:50:22 PDT
Comment on
attachment 157217
[details]
Don't share styles for accelerated canvases I don't think you can CQ this because you removed the Reviewed By: line, but let's try and see how smart the scripts are :)
WebKit Review Bot
Comment 5
2012-08-08 19:07:03 PDT
Comment on
attachment 157217
[details]
Don't share styles for accelerated canvases Rejecting
attachment 157217
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/13455733
Simon Fraser (smfr)
Comment 6
2012-08-08 19:49:27 PDT
Comment on
attachment 157217
[details]
Don't share styles for accelerated canvases Looking through the canvas code, we usually do USE(IOSURFACE_CANVAS_BACKING_STORE) || ENABLE(ACCELERATED_2D_CANVAS). The latter is not used for Mac builds, confusingly.
Filip Spacek
Comment 7
2012-08-09 18:39:46 PDT
Created
attachment 157608
[details]
Don't share styles for accelerated canvases
Simon Fraser (smfr)
Comment 8
2012-08-09 19:48:18 PDT
I think you should try to make a testcase for this.
George Staikos
Comment 9
2012-08-09 20:17:51 PDT
(In reply to
comment #6
)
> (From update of
attachment 157217
[details]
) > Looking through the canvas code, we usually do USE(IOSURFACE_CANVAS_BACKING_STORE) || ENABLE(ACCELERATED_2D_CANVAS). The latter is not used for Mac builds, confusingly.
We need to unify this. It's really not clear (In reply to
comment #8
)
> I think you should try to make a testcase for this.
Is there a way to test something like this? Seems ... challenging.
Simon Fraser (smfr)
Comment 10
2012-08-10 11:00:30 PDT
(In reply to
comment #9
)
> (In reply to
comment #6
) > > (From update of
attachment 157217
[details]
[details]) > > Looking through the canvas code, we usually do USE(IOSURFACE_CANVAS_BACKING_STORE) || ENABLE(ACCELERATED_2D_CANVAS). The latter is not used for Mac builds, confusingly. > > We need to unify this. It's really not clear
Agreed.
> (In reply to
comment #8
) > > I think you should try to make a testcase for this. > > Is there a way to test something like this? Seems ... challenging.
If you look at the history for some of the other "don't share style" criteria, you may find testcases. I recall making one for iframes, I think.
Tim Horton
Comment 11
2013-04-19 14:26:49 PDT
Comment on
attachment 157608
[details]
Don't share styles for accelerated canvases r- to remove from the review queue until there's a test.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug