WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93480
[BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate method.
https://bugs.webkit.org/show_bug.cgi?id=93480
Summary
[BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate ...
Antonio Gomes
Reported
2012-08-08 07:41:01 PDT
PR #188682 ... this way it can be used by others
Attachments
patch
(4.19 KB, patch)
2012-08-08 08:29 PDT
,
Antonio Gomes
no flags
Details
Formatted Diff
Diff
patch - fixed style errors
(4.15 KB, patch)
2012-08-08 09:28 PDT
,
Antonio Gomes
rwlbuis
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Antonio Gomes
Comment 1
2012-08-08 08:29:38 PDT
Created
attachment 157226
[details]
patch
WebKit Review Bot
Comment 2
2012-08-08 08:33:28 PDT
Attachment 157226
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebOverlay.cp..." exit_code: 1 Source/WebKit/blackberry/Api/WebPage.cpp:149: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antonio Gomes
Comment 3
2012-08-08 09:28:11 PDT
Created
attachment 157236
[details]
patch - fixed style errors
Rob Buis
Comment 4
2012-08-08 09:31:52 PDT
Comment on
attachment 157236
[details]
patch - fixed style errors LGTM.
Antonio Gomes
Comment 5
2012-08-08 12:24:18 PDT
Committed <
http://trac.webkit.org/changeset/125070
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug