Bug 93478 – [BlackBerry] Propagate GraphicsLayer::boundsOrigin down to the platform layers

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Antonio Gomes]

PR #188657

This property is being used to translate hardware accelerated "Layers", for
fast scrolling (primarily blocks, i.e. divs and friends).

We need to support it therefore.

[Antonio Gomes]

Created attachment 157221 [details]
patch

[Yong Li]

Comment on attachment 157221 [details]
patch

Not familiar with InRegion scroller. But this patch looks good to me

[Antonio Gomes]

Committed <http://trac.webkit.org/changeset/125068>

[Arvid Nilsson]

Comment on attachment 157221 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157221&action=review

Just one comment

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h:136
> +    void setBoundsOrigin(const FloatPoint& boundsOrigin) { m_boundsOrigin = boundsOrigin; }

I think this is dead code, since you started using LayerOverride::setBoundsOrigin() instead. The only reason to place a setter in this block is if you want to be able to run a LayerAnimation on that property, or if you expose boundsOrigin in the WebOverlay API.

[Antonio Gomes]

(In reply to comment #4)
> (From update of attachment 157221 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157221&action=review
> 
> Just one comment
> 
> > Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h:136
> > +    void setBoundsOrigin(const FloatPoint& boundsOrigin) { m_boundsOrigin = boundsOrigin; }
> 
> I think this is dead code, since you started using LayerOverride::setBoundsOrigin() instead. The only reason to place a setter in this block is if you want to be able to run a LayerAnimation on that property, or if you expose boundsOrigin in the WebOverlay API.

True. Will clean up...