Bug 93478 - [BlackBerry] Propagate GraphicsLayer::boundsOrigin down to the platform layers
Summary: [BlackBerry] Propagate GraphicsLayer::boundsOrigin down to the platform layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks: 93479 93482
  Show dependency treegraph
 
Reported: 2012-08-08 07:38 PDT by Antonio Gomes
Modified: 2012-08-09 09:32 PDT (History)
6 users (show)

See Also:


Attachments
patch (8.27 KB, patch)
2012-08-08 08:17 PDT, Antonio Gomes
yong.li.webkit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-08-08 07:38:40 PDT
PR #188657

This property is being used to translate hardware accelerated "Layers", for
fast scrolling (primarily blocks, i.e. divs and friends).

We need to support it therefore.
Comment 1 Antonio Gomes 2012-08-08 08:17:40 PDT
Created attachment 157221 [details]
patch
Comment 2 Yong Li 2012-08-08 09:37:06 PDT
Comment on attachment 157221 [details]
patch

Not familiar with InRegion scroller. But this patch looks good to me
Comment 3 Antonio Gomes 2012-08-08 12:24:53 PDT
Committed <http://trac.webkit.org/changeset/125068>
Comment 4 Arvid Nilsson 2012-08-09 00:58:05 PDT
Comment on attachment 157221 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157221&action=review

Just one comment

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h:136
> +    void setBoundsOrigin(const FloatPoint& boundsOrigin) { m_boundsOrigin = boundsOrigin; }

I think this is dead code, since you started using LayerOverride::setBoundsOrigin() instead. The only reason to place a setter in this block is if you want to be able to run a LayerAnimation on that property, or if you expose boundsOrigin in the WebOverlay API.
Comment 5 Antonio Gomes 2012-08-09 09:32:36 PDT
(In reply to comment #4)
> (From update of attachment 157221 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157221&action=review
> 
> Just one comment
> 
> > Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h:136
> > +    void setBoundsOrigin(const FloatPoint& boundsOrigin) { m_boundsOrigin = boundsOrigin; }
> 
> I think this is dead code, since you started using LayerOverride::setBoundsOrigin() instead. The only reason to place a setter in this block is if you want to be able to run a LayerAnimation on that property, or if you expose boundsOrigin in the WebOverlay API.

True. Will clean up...