Bug 93464 - Rename two methods of BitmapImage in order to clarify the intention: frameDurationAtIndex() and frameIsCompleteAtIndex().
Summary: Rename two methods of BitmapImage in order to clarify the intention: frameDur...
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 90375 93467
  Show dependency treegraph
 
Reported: 2012-08-08 04:58 PDT by Dongseong Hwang
Modified: 2014-02-05 10:51 PST (History)
7 users (show)

See Also:


Attachments
Patch (12.20 KB, patch)
2012-08-08 05:00 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2012-08-09 00:10 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (6.07 KB, patch)
2012-08-09 00:44 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (6.18 KB, patch)
2012-08-15 23:24 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-08-08 04:58:25 PDT
There are three methods which can trigger image decoding:
ImageSource::createFrameAtIndex()
ImageSource::frameIsCompleteAtIndex()
ImageSource::frameDurationAtIndex()

frameIsCompleteAtIndex() and frameDurationAtIndex() make us confused because
both methods can trigger image decoding although the name of both methods do not
look so.
This patch renames frameDurationAtIndex() and frameIsCompleteAtIndex() to
frameDurationAtIndexDecodingIfNecessary() and
frameIsCompleteAtIndexDecodingIfNecessary() respectively.
BitmapImage has the wrappers of both methods, so this patch renames those
wrappers too.

It is a preparation patch for implementing an async image decoder.
Both methods are not plane getters, so developers need to be careful
when using these methods. Otherwise, sync or async image
decoding will be triggered, which is an unexpected behavior.
Comment 1 Dongseong Hwang 2012-08-08 05:00:59 PDT
Created attachment 157184 [details]
Patch
Comment 2 Gyuyoung Kim 2012-08-08 05:15:22 PDT
Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13457443
Comment 3 WebKit Review Bot 2012-08-08 05:23:54 PDT
Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13462063
Comment 4 Early Warning System Bot 2012-08-08 05:30:33 PDT
Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13461133
Comment 5 Early Warning System Bot 2012-08-08 05:43:46 PDT
Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13458238
Comment 6 Gustavo Noronha (kov) 2012-08-08 06:10:38 PDT
Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13454493
Comment 7 Dongseong Hwang 2012-08-08 19:17:19 PDT
This patch was implemented based on Bug 93171, so all build bots failed.
I'll post this patch again after landing Bug 93171.
Comment 8 Dongseong Hwang 2012-08-09 00:10:43 PDT
Created attachment 157403 [details]
Patch
Comment 9 Dongseong Hwang 2012-08-09 00:26:17 PDT
(In reply to comment #8)
> Created an attachment (id=157403) [details]
> Patch

The first patch renamed two methods of ImageSource as well as two methods of BitmapImage. But this patch renamed only those of BitmapImage, because Bug 93467 prevents clients, except for BitmapImage, from using two methods of ImageSource.
Comment 10 Build Bot 2012-08-09 00:32:48 PDT
Comment on attachment 157403 [details]
Patch

Attachment 157403 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13458598
Comment 11 Build Bot 2012-08-09 00:35:08 PDT
Comment on attachment 157403 [details]
Patch

Attachment 157403 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13462388
Comment 12 Dongseong Hwang 2012-08-09 00:44:57 PDT
Created attachment 157409 [details]
Patch
Comment 13 Dongseong Hwang 2012-08-15 23:24:46 PDT
Created attachment 158718 [details]
Patch
Comment 14 Dongseong Hwang 2012-08-15 23:26:21 PDT
(In reply to comment #13)
> Created an attachment (id=158718) [details]
> Patch

Rebased to the upstream
Comment 15 Andreas Kling 2014-02-05 10:51:25 PST
Comment on attachment 158718 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.