Bug 93464 – Rename two methods of BitmapImage in order to clarify the intention: frameDurationAtIndex() and frameIsCompleteAtIndex().

• Status: UNCONFIRMED
• Component: Images

[Dongseong Hwang]

There are three methods which can trigger image decoding:
ImageSource::createFrameAtIndex()
ImageSource::frameIsCompleteAtIndex()
ImageSource::frameDurationAtIndex()

frameIsCompleteAtIndex() and frameDurationAtIndex() make us confused because
both methods can trigger image decoding although the name of both methods do not
look so.
This patch renames frameDurationAtIndex() and frameIsCompleteAtIndex() to
frameDurationAtIndexDecodingIfNecessary() and
frameIsCompleteAtIndexDecodingIfNecessary() respectively.
BitmapImage has the wrappers of both methods, so this patch renames those
wrappers too.

It is a preparation patch for implementing an async image decoder.
Both methods are not plane getters, so developers need to be careful
when using these methods. Otherwise, sync or async image
decoding will be triggered, which is an unexpected behavior.

[Dongseong Hwang]

Created attachment 157184 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13457443

[WebKit Review Bot]

Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13462063

[Early Warning System Bot]

Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13461133

[Early Warning System Bot]

Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13458238

[Gustavo Noronha (kov)]

Comment on attachment 157184 [details]
Patch

Attachment 157184 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13454493

[Dongseong Hwang]

This patch was implemented based on Bug 93171, so all build bots failed.
I'll post this patch again after landing Bug 93171.

[Dongseong Hwang]

Created attachment 157403 [details]
Patch

[Dongseong Hwang]

(In reply to comment #8)
> Created an attachment (id=157403) [details]
> Patch

The first patch renamed two methods of ImageSource as well as two methods of BitmapImage. But this patch renamed only those of BitmapImage, because Bug 93467 prevents clients, except for BitmapImage, from using two methods of ImageSource.

[Build Bot]

Comment on attachment 157403 [details]
Patch

Attachment 157403 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13458598

[Build Bot]

Comment on attachment 157403 [details]
Patch

Attachment 157403 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13462388

[Dongseong Hwang]

Created attachment 157409 [details]
Patch

[Dongseong Hwang]

Created attachment 158718 [details]
Patch

[Dongseong Hwang]

(In reply to comment #13)
> Created an attachment (id=158718) [details]
> Patch

Rebased to the upstream

[Andreas Kling]

Comment on attachment 158718 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.