Bug 93459 - [EFL] Change ordering of sources in the PlatformEfl.cmake
Summary: [EFL] Change ordering of sources in the PlatformEfl.cmake
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 04:20 PDT by Kihong Kwon
Modified: 2012-08-08 04:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2012-08-08 04:22 PDT, Kihong Kwon 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-08-08 04:20:33 PDT 
There is a wrong ordered line in the APPEND WebKit_SOURCES.
Fix ordering of sources by alphabetical order.
Comment 1 Kihong Kwon 2012-08-08 04:22:35 PDT 
Created attachment 157178 [details]
Patch
Comment 2 Gyuyoung Kim 2012-08-08 04:36:31 PDT 
Comment on attachment 157178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157178&action=review

I was told that WebKit culturally doesn't fix only style errors. It is better to fix this together with other bugs.

> Source/WebKit/ChangeLog:6
> +        Unreviewed EFL gardening.

This is not efl gardening.
Comment 3 Kihong Kwon 2012-08-08 04:37:17 PDT 
(In reply to comment #2)
> (From update of attachment 157178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157178&action=review
> 
> I was told that WebKit culturally doesn't fix only style errors. It is better to fix this together with other bugs.
> 
> > Source/WebKit/ChangeLog:6
> > +        Unreviewed EFL gardening.
> 
> This is not efl gardening.

OK.