RESOLVED FIXED 93457
[WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const 
https://bugs.webkit.org/show_bug.cgi?id=93457
Summary [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCall...
Mikhail Pozdnyakov
Reported 2012-08-08 02:24:24 PDT
LayoutTestController::shouldDumpProgressFinishedCallback() should be const.
Attachments
patch (1.73 KB, patch)
2012-08-08 02:27 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-08-08 02:27:40 PDT
Created attachment 157163 [details] patch
Chris Dumez
Comment 2 2012-08-08 02:33:07 PDT
Comment on attachment 157163 [details] patch LGTM.
Csaba Osztrogonác
Comment 3 2012-08-08 02:37:44 PDT
Comment on attachment 157163 [details] patch rs=me
WebKit Review Bot
Comment 4 2012-08-08 04:20:56 PDT
Comment on attachment 157163 [details] patch Clearing flags on attachment: 157163 Committed r125019: <http://trac.webkit.org/changeset/125019>
WebKit Review Bot
Comment 5 2012-08-08 04:21:00 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2012-08-08 10:30:53 PDT
In the future, please provide rationale for changes. One can only guess why you needed this: - No actual impact, just for consistency with other getters? - Because this was breaking build for some platforms? - Because your personal preferred coding style is to have const on all methods that could have it? Also, is this some code that you just added, and are cleaning it up, or a long standing issue? That's also useful information, and others should not resort to svn blame to get it.
Note You need to log in before you can comment on or make changes to this bug.