WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93451
Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451
Summary
Web Inspector: Search matches count view is flaky.
sam
Reported
2012-08-08 01:40:40 PDT
Created
attachment 157150
[details]
problem illustration 1). Ctrl+f to open a search panel. 2). Type any value to be searched. 3). Observe the match count on right side of input ex. {2 of 121} This match count view is getting blocked. I have attached a screenshot for illustration. Will upload a patch.
Attachments
problem illustration
(40.60 KB, image/png)
2012-08-08 01:40 PDT
,
sam
no flags
Details
Patch
(3.04 KB, patch)
2012-08-09 22:46 PDT
,
sam
no flags
Details
Formatted Diff
Diff
Patch
(1.22 KB, patch)
2012-08-09 23:49 PDT
,
sam
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
sam
Comment 1
2012-08-09 22:46:23 PDT
Created
attachment 157641
[details]
Patch
Pavel Feldman
Comment 2
2012-08-09 23:03:06 PDT
Comment on
attachment 157641
[details]
Patch Clearing r+, cq+. I am not sure what is happening in this change.
Pavel Feldman
Comment 3
2012-08-09 23:10:31 PDT
Comment on
attachment 157641
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=157641&action=review
The right fix is to change .search-results-matches to have { min-width: 50px; margin-right: 36px; }
> Source/WebCore/inspector/front-end/inspector.css:289 > + float: left;
you should not do float: left for two components belonging to the same container.
sam
Comment 4
2012-08-09 23:49:29 PDT
Created
attachment 157646
[details]
Patch
WebKit Review Bot
Comment 5
2012-08-10 00:28:59 PDT
Comment on
attachment 157646
[details]
Patch Clearing flags on attachment: 157646 Committed
r125255
: <
http://trac.webkit.org/changeset/125255
>
WebKit Review Bot
Comment 6
2012-08-10 00:29:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug