Bug 93449 – [EFL] Fixed slider thumb position on vertical slider

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit EFL

[KwangYong Choi]

The UI and slider coordinates are reversed in case of vertical slider. So, it's required to convert the slider thumb position reversed.

The minimum value of the vertical slider is on the bottom. But,the minimum value of the UI is on the top.

[KwangYong Choi]

Created attachment 157152 [details]
Patch

[WebKit Review Bot]

Comment on attachment 157152 [details]
Patch

Attachment 157152 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13456418

New failing tests:
fast/forms/range/slider-thumb-initial-position-vertical.html

[WebKit Review Bot]

Created attachment 157164 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[KwangYong Choi]

Created attachment 157173 [details]
Patch

Added test result for cr-linux.

I think, all the other ports can pass this test. I'll check and provide expected result for the others.

[Gyuyoung Kim]

Comment on attachment 157173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157173&action=review

> LayoutTests/ChangeLog:13
> +        * platform/efl/fast/forms/range/slider-thumb-initial-position-vertical-expected.txt: Added.

It looks test cases for chromium port are missing in ChangeLog.

platform/chromium-linux/fast/forms/range/slider-thumb-initial-position-vertical-expected.png
platform/chromium-linux/fast/forms/range/slider-thumb-initial-position-vertical-expected.txt

[KwangYong Choi]

> 
> It looks test cases for chromium port are missing in ChangeLog.
> 
> platform/chromium-linux/fast/forms/range/slider-thumb-initial-position-vertical-expected.png
> platform/chromium-linux/fast/forms/range/slider-thumb-initial-position-vertical-expected.txt

You're right. I will add these to ChangeLog.

I have a question. Do you know why EWS don't show mac port? I try to add expected result for mac port, but it's not checked by EWS. Isn't it necessary to provide?

[Gyuyoung Kim]

(In reply to comment #6)
 
> I have a question. Do you know why EWS don't show mac port? I try to add expected result for mac port, but it's not checked by EWS. Isn't it necessary to provide?

Because mac ews is disappeared when pending patches are over 100. Now, mac ews is disappeared because of many pending patches. 

http://webkit-commit-queue.appspot.com/queue-status/mac-ews

If you need to add a test case to mac port, you have to check if your patch is ok on Mac port as well.

[KwangYong Choi]

Created attachment 157374 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 157374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157374&action=review

> LayoutTests/ChangeLog:17
> +        * platform/mac/fast/forms/range/slider-thumb-initial-position-vertical-expected.txt: Added.

Will you support gtk, qt ports as well? If not, you need to add these tests to it's Skipped file.

[KwangYong Choi]

Comment on attachment 157374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157374&action=review

>> LayoutTests/ChangeLog:17
>> +        * platform/mac/fast/forms/range/slider-thumb-initial-position-vertical-expected.txt: Added.
> 
> Will you support gtk, qt ports as well? If not, you need to add these tests to it's Skipped file.

Gyuyoung, I want to make this test as EFL specific. The other ports will work fine. It's about simple slider thumb display thing. But, it's too hard to make expected result on all the other ports.

From my observation, there are many platform specific tests on LayoutTests/platform directory. I think it's possible to make it as EFL platform specific. What do you think?

[KwangYong Choi]

Actually, this patch can be tested with fast/forms/datalist/input-appearance-range-with-datalist.html which has vertical slider with initial value.

But, vertical slider is not displayed properly because the applied theme for vertical slider is same as horizontal slider. So, the height value of the vertical slider is too small. It should be fixed first to pass the above range with datalist test.

I may remove the test in this patch after I fix vertical slider theme problem.

[Gyuyoung Kim]

(In reply to comment #11)
> Actually, this patch can be tested with fast/forms/datalist/input-appearance-range-with-datalist.html which has vertical slider with initial value.
> 
> But, vertical slider is not displayed properly because the applied theme for vertical slider is same as horizontal slider. So, the height value of the vertical slider is too small. It should be fixed first to pass the above range with datalist test.
> I may remove the test in this patch after I fix vertical slider theme problem.

I think you can feel free to modify this patch according to your consideration.

> From my observation, there are many platform specific tests on LayoutTests/platform directory. I think it's possible to make it as EFL platform specific. What do you think?

If there is proper reason to have efl specific test case, I think EFL port can have the specific test case as mac, gtk and qt ports

[KwangYong Choi]

Created attachment 160125 [details]
Patch

This patch is can be tested by fast/forms/datalist/fast/forms/datalist/input-appearance-range-with-datalist.html now.

[KwangYong Choi]

*** This bug has been marked as a duplicate of bug 94595 ***

[Gyuyoung Kim]

Comment on attachment 160125 [details]
Patch

Clearing r?