WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93441
Web Inspector: show white space nodes if they are the only tag's children.
https://bugs.webkit.org/show_bug.cgi?id=93441
Summary
Web Inspector: show white space nodes if they are the only tag's children.
Pavel Feldman
Reported
2012-08-07 23:49:53 PDT
As of today, span with textContent === " " will show up in the UI as <span></span>. The reason is that we filter out whitespace entirely form the inspector UI. This change makes an exception and renders the white space if it is the only element's child.
Attachments
Patch
(4.28 KB, patch)
2012-08-07 23:54 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-08-07 23:54:02 PDT
Created
attachment 157132
[details]
Patch
Vsevolod Vlasov
Comment 2
2012-08-08 00:53:09 PDT
Comment on
attachment 157132
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=157132&action=review
> Source/WebCore/inspector/InspectorDOMAgent.cpp:1286 > + if (firstChild && firstChild->nodeType() == Node::TEXT_NODE && !firstChild->nextSibling()) {
innerNextSibling instead of nextSibling?
WebKit Review Bot
Comment 3
2012-08-08 03:16:17 PDT
Comment on
attachment 157132
[details]
Patch Clearing flags on attachment: 157132 Committed
r125014
: <
http://trac.webkit.org/changeset/125014
>
WebKit Review Bot
Comment 4
2012-08-08 03:16:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug