RESOLVED FIXED 93429
Make slider tick mark snapping threshold configurable for each platform 
https://bugs.webkit.org/show_bug.cgi?id=93429
Summary Make slider tick mark snapping threshold configurable for each platform
Keishi Hattori
Reported 2012-08-07 20:36:57 PDT
We should increase the slider tick mark snapping threshold.
Attachments
Patch (13.38 KB, patch)
2012-08-07 22:41 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (14.67 KB, patch)
2012-08-07 23:46 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-08-07 22:41:19 PDT
Created attachment 157118 [details] Patch
Kent Tamura
Comment 2 2012-08-07 22:52:39 PDT
Comment on attachment 157118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157118&action=review > Source/WebCore/rendering/RenderTheme.h:219 > + virtual LayoutUnit sliderTickSnappingThreshold() const { return 0; } nit: We had better put the function body to RenderTheme.cpp because inline function definition for a virtual function wastes compilation cost. > LayoutTests/platform/chromium/fast/forms/datalist/range-snap-to-datalist-expected.txt:1 > +Tests if clicking close to a tick mark snaps to it. You had better mention the test result depends on RenderTheme::sliderTickSnappingThreshold() value.
Keishi Hattori
Comment 3 2012-08-07 23:46:58 PDT
Created attachment 157131 [details] Patch
WebKit Review Bot
Comment 4 2012-08-08 10:31:29 PDT
Comment on attachment 157131 [details] Patch Clearing flags on attachment: 157131 Committed r125048: <http://trac.webkit.org/changeset/125048>
WebKit Review Bot
Comment 5 2012-08-08 10:31:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.