Bug 93429 - Make slider tick mark snapping threshold configurable for each platform
Summary: Make slider tick mark snapping threshold configurable for each platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 20:36 PDT by Keishi Hattori
Modified: 2012-08-08 10:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (13.38 KB, patch)
2012-08-07 22:41 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (14.67 KB, patch)
2012-08-07 23:46 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-08-07 20:36:57 PDT
We should increase the slider tick mark snapping threshold.
Comment 1 Keishi Hattori 2012-08-07 22:41:19 PDT
Created attachment 157118 [details]
Patch
Comment 2 Kent Tamura 2012-08-07 22:52:39 PDT
Comment on attachment 157118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157118&action=review

> Source/WebCore/rendering/RenderTheme.h:219
> +    virtual LayoutUnit sliderTickSnappingThreshold() const { return 0; }

nit: We had better put the function body to RenderTheme.cpp because inline function definition for a virtual function wastes compilation cost.

> LayoutTests/platform/chromium/fast/forms/datalist/range-snap-to-datalist-expected.txt:1
> +Tests if clicking close to a tick mark snaps to it.

You had better mention the test result depends on RenderTheme::sliderTickSnappingThreshold() value.
Comment 3 Keishi Hattori 2012-08-07 23:46:58 PDT
Created attachment 157131 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-08 10:31:29 PDT
Comment on attachment 157131 [details]
Patch

Clearing flags on attachment: 157131

Committed r125048: <http://trac.webkit.org/changeset/125048>
Comment 5 WebKit Review Bot 2012-08-08 10:31:32 PDT
All reviewed patches have been landed.  Closing bug.