Bug 93426 - Add support for String initialization from literal to WTFString
Summary: Add support for String initialization from literal to WTFString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 93402
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-07 19:45 PDT by Benjamin Poulain
Modified: 2012-08-10 13:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.83 KB, patch)
2012-08-07 20:01 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (15.73 KB, patch)
2012-08-08 22:10 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-07 19:45:43 PDT 
Add support for String initialization from literal to WTFString
Comment 1 Benjamin Poulain 2012-08-07 20:01:52 PDT 
Created attachment 157091 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-07 20:05:05 PDT 
Attachment 157091 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:36:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:43:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-08-07 20:25:53 PDT 
Comment on attachment 157091 [details]
Patch

Attachment 157091 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13450687
Comment 4 Build Bot 2012-08-07 20:28:57 PDT 
Comment on attachment 157091 [details]
Patch

Attachment 157091 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13457284
Comment 5 WebKit Review Bot 2012-08-07 20:29:45 PDT 
Comment on attachment 157091 [details]
Patch

Attachment 157091 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13453469
Comment 6 Early Warning System Bot 2012-08-07 20:29:56 PDT 
Comment on attachment 157091 [details]
Patch

Attachment 157091 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13457285
Comment 7 Gyuyoung Kim 2012-08-07 22:37:51 PDT 
Comment on attachment 157091 [details]
Patch

Attachment 157091 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13461009
Comment 8 Build Bot 2012-08-08 15:10:48 PDT 
Comment on attachment 157091 [details]
Patch

Attachment 157091 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13457608
Comment 9 Benjamin Poulain 2012-08-08 22:10:30 PDT 
Created attachment 157385 [details]
Patch
Comment 10 WebKit Review Bot 2012-08-08 22:45:16 PDT 
Attachment 157385 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:36:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:43:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Benjamin Poulain 2012-08-10 13:18:20 PDT 
Comment on attachment 157385 [details]
Patch

Clearing flags on attachment: 157385

Committed r125320: <http://trac.webkit.org/changeset/125320>
Comment 12 Benjamin Poulain 2012-08-10 13:18:24 PDT 
All reviewed patches have been landed.  Closing bug.