Bug 93423 – [chromium] Only use public Platform API in NonCompositedContentHost

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[James Robinson]

[chromium] Only use public Platform API in NonCompositedContentHost

[James Robinson]

Created attachment 157084 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adrienne Walker]

Comment on attachment 157084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157084&action=review

R=me, with one comment nit.

> Source/WebCore/ChangeLog:10
> +        This renames the "NonCompositedContentHost" flag to "useLCDText", which is the primary purpose of the flag. We
> +        also use this flag to control whether we have border texels or not on the "root" layer, but I can't think of a
> +        clean name that encapsulates both behaviors.

That's a way better name.  If you know you're using LCD text then you also know that the layer can't have a transform that's anything other than an integer translation, so therefore doesn't need border texels.  Therefore, I'd argue that it encapsulates both.

> Source/Platform/chromium/public/WebContentLayer.h:70
> +    // Set to draw a system-defined checkerboard if the compositor would otherwise draw a tile in this layer
> +    // and the actual contents are unavailable. If false, the compositor will just draw nothing for these tiles.
> +    // Defaults to false.

If false, I think we draw the background color of that layer?

[James Robinson]

(In reply to comment #3)
> 
> > Source/Platform/chromium/public/WebContentLayer.h:70
> > +    // Set to draw a system-defined checkerboard if the compositor would otherwise draw a tile in this layer
> > +    // and the actual contents are unavailable. If false, the compositor will just draw nothing for these tiles.
> > +    // Defaults to false.
> 
> If false, I think we draw the background color of that layer?

Ah yes, I was mistaken.

[James Robinson]

Committed r125088: <http://trac.webkit.org/changeset/125088>