Bug 93417 - Add MountainLion Webkit bots
Summary: Add MountainLion Webkit bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 17:50 PDT by Lucas Forschler
Modified: 2012-08-08 13:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch for config.json which adds mountain lion slaves, builders, and schedulers (6.82 KB, patch)
2012-08-07 17:55 PDT, Josh Hawn 		no flags Details | Formatted Diff | Diff
patch for config.json which adds mountain lion slaves, builders, and schedulers (7.34 KB, patch)
2012-08-07 18:07 PDT, Josh Hawn 		slewis: review-
slewis: commit-queue-
Details | Formatted Diff | Diff
patch for config.json with ChangeLog entry. (8.06 KB, patch)
2012-08-08 10:29 PDT, Josh Hawn 		slewis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Updated patch (7.56 KB, patch)
2012-08-08 12:58 PDT, Josh Hawn 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2012-08-07 17:50:57 PDT 
Mountain Lion is available.  Add the appropriate Apple bots.
Match the Lion bots with ML bots.
Comment 1 Josh Hawn 2012-08-07 17:55:02 PDT 
Created attachment 157061 [details]
Patch for config.json which adds mountain lion slaves, builders, and schedulers
Comment 2 WebKit Review Bot 2012-08-07 17:57:34 PDT 
Attachment 157061 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1
Tools/BuildSlaveSupport/build.webkit.org-config/config.json:77:  Expecting object: line 77 column 19 (char 4740)  [json/syntax] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas Forschler 2012-08-07 17:59:50 PDT 
Comment on attachment 157061 [details]
Patch for config.json which adds mountain lion slaves, builders, and schedulers

View in context: https://bugs.webkit.org/attachment.cgi?id=157061&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:126
> +                    { "name": "Apple MountainLion Debug (Build)", "type": "Build", "builddir": "lion-debug",

builddir should be mountainlion-debug
Comment 4 Stephanie Lewis 2012-08-07 18:05:21 PDT 
That style fail seems to be a legitimate json syntax error.  I'm surprised the current config is working.   FIx that and the typo and I'll r+ it.
Comment 5 Josh Hawn 2012-08-07 18:07:49 PDT 
Created attachment 157064 [details]
patch for config.json which adds mountain lion slaves, builders, and schedulers
Comment 6 Stephanie Lewis 2012-08-07 18:55:15 PDT 
This needs a changelog before it can be checked in.
Comment 7 Josh Hawn 2012-08-08 10:29:53 PDT 
Created attachment 157247 [details]
patch for config.json with ChangeLog entry.
Comment 8 WebKit Review Bot 2012-08-08 12:23:31 PDT 
Comment on attachment 157247 [details]
patch for config.json with ChangeLog entry.

Rejecting attachment 157247 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Hunk #2 FAILED at 73.
1 out of 5 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/config.json.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Stephanie ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13459315
Comment 9 Josh Hawn 2012-08-08 12:58:11 PDT 
Created attachment 157274 [details]
Updated patch

It looks like someone else already fixed the invalid json bug, which is why the commit queue refused my earlier patch. I did a local git-pull and it was fixed.
Comment 10 WebKit Review Bot 2012-08-08 13:50:00 PDT 
Comment on attachment 157274 [details]
Updated patch

Clearing flags on attachment: 157274

Committed r125082: <http://trac.webkit.org/changeset/125082>
Comment 11 WebKit Review Bot 2012-08-08 13:50:04 PDT 
All reviewed patches have been landed.  Closing bug.