Bug 93417 – Add MountainLion Webkit bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Lucas Forschler]

Mountain Lion is available.  Add the appropriate Apple bots.
Match the Lion bots with ML bots.

[Josh Hawn]

Created attachment 157061 [details]
Patch for config.json which adds mountain lion slaves, builders, and schedulers

[WebKit Review Bot]

Attachment 157061 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1
Tools/BuildSlaveSupport/build.webkit.org-config/config.json:77:  Expecting object: line 77 column 19 (char 4740)  [json/syntax] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lucas Forschler]

Comment on attachment 157061 [details]
Patch for config.json which adds mountain lion slaves, builders, and schedulers

View in context: https://bugs.webkit.org/attachment.cgi?id=157061&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:126
> +                    { "name": "Apple MountainLion Debug (Build)", "type": "Build", "builddir": "lion-debug",

builddir should be mountainlion-debug

[Stephanie Lewis]

That style fail seems to be a legitimate json syntax error.  I'm surprised the current config is working.   FIx that and the typo and I'll r+ it.

[Josh Hawn]

Created attachment 157064 [details]
patch for config.json which adds mountain lion slaves, builders, and schedulers

[Stephanie Lewis]

This needs a changelog before it can be checked in.

[Josh Hawn]

Created attachment 157247 [details]
patch for config.json with ChangeLog entry.

[WebKit Review Bot]

Comment on attachment 157247 [details]
patch for config.json with ChangeLog entry.

Rejecting attachment 157247 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Hunk #2 FAILED at 73.
1 out of 5 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/config.json.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Stephanie ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13459315

[Josh Hawn]

Created attachment 157274 [details]
Updated patch

It looks like someone else already fixed the invalid json bug, which is why the commit queue refused my earlier patch. I did a local git-pull and it was fixed.

[WebKit Review Bot]

Comment on attachment 157274 [details]
Updated patch

Clearing flags on attachment: 157274

Committed r125082: <http://trac.webkit.org/changeset/125082>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.