RESOLVED FIXED 93413
[WK2] MiniBrowser crashes on window.open() 
https://bugs.webkit.org/show_bug.cgi?id=93413
Summary [WK2] MiniBrowser crashes on window.open()
Alexey Proskuryakov
Reported 2012-08-07 17:07:04 PDT
Patch forthcoming.
Attachments
proposed fix (2.19 KB, patch)
2012-08-07 17:09 PDT, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-08-07 17:09:25 PDT
Created attachment 157049 [details] proposed fix
Simon Hausmann
Comment 2 2012-08-08 01:29:43 PDT
Comment on attachment 157049 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=157049&action=review > Tools/MiniBrowser/mac/WebBundle/WebBundleMain.m:48 > LOG(@"WKBundlePageClient - didClearWindowForFrame %@", [(NSURL *)cfURL absoluteString]); > - CFRelease(cfURL); > + if (cfURL) > + CFRelease(cfURL); Just out of curiousity, if cfURL can be a null pointer, isn't the previous call to absoluteString in the LOG line going to crash?
mitz
Comment 3 2012-08-08 09:26:44 PDT
Comment on attachment 157049 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=157049&action=review >> Tools/MiniBrowser/mac/WebBundle/WebBundleMain.m:48 >> + CFRelease(cfURL); > > Just out of curiousity, if cfURL can be a null pointer, isn't the previous call to absoluteString in the LOG line going to crash? It isn’t. Sending an Objective-C message to nil is safe.
Alexey Proskuryakov
Comment 4 2012-08-08 09:32:33 PDT
Committed <http://trac.webkit.org/changeset/125040>.
Note You need to log in before you can comment on or make changes to this bug.