Bug 93410 - IndexedDB: new enums and openCursor stub
Summary: IndexedDB: new enums and openCursor stub
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks: 91125
  Show dependency treegraph
 
Reported: 2012-08-07 16:45 PDT by Alec Flett
Modified: 2012-08-08 14:04 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2012-08-07 16:49 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2012-08-08 09:37 PDT, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-08-07 16:45:28 PDT
IndexedDB: new enums and openCursor stub
Comment 1 Alec Flett 2012-08-07 16:49:43 PDT
Created attachment 157044 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-07 16:51:01 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Alec Flett 2012-08-07 16:52:16 PDT
Only open choice at this point is naming on "EarlyTask" - these are basically higher-priority, internal tasks. for the full landing of bug 91125, these are specifically continueFunctionInternal and setIndexesReady (also stubbed out in this patch)

jsbell, dgrogan, any input is welcome on naming - the rest of the patch is fairly dull.
Comment 4 David Grogan 2012-08-07 18:36:53 PDT
Comment on attachment 157044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157044&action=review

> Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54
> +        EarlyTask // InternalTask? GardeningTask?

HighPriorityTask?  PreemptiveTask?

> Source/WebKit/chromium/public/WebIDBObjectStore.h:29
>  #include "WebDOMStringList.h"

Heh, fail.
Comment 5 Joshua Bell 2012-08-07 20:44:20 PDT
(In reply to comment #4)
> (From update of attachment 157044 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157044&action=review
> 
> > Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54
> > +        EarlyTask // InternalTask? GardeningTask?
> 
> HighPriorityTask?  PreemptiveTask?

I like PreemptiveTask.

Does this need to be in Interface or can it be in Impl?
Comment 6 Joshua Bell 2012-08-07 20:45:45 PDT
(In reply to comment #5)
> 
> Does this need to be in Interface or can it be in Impl?

Never mind, I see how it's used now.
Comment 7 Alec Flett 2012-08-08 09:37:50 PDT
Created attachment 157238 [details]
Patch
Comment 8 Alec Flett 2012-08-08 09:39:14 PDT
tkent@ - r? just stubbing some stuff out for a chromium landing
Comment 9 Alec Flett 2012-08-08 13:35:56 PDT
(keep forgetting about timezones...)

abarth@ - r?
Comment 10 Adam Barth 2012-08-08 13:39:12 PDT
Comment on attachment 157238 [details]
Patch

ok
Comment 11 WebKit Review Bot 2012-08-08 14:04:52 PDT
Comment on attachment 157238 [details]
Patch

Clearing flags on attachment: 157238

Committed r125084: <http://trac.webkit.org/changeset/125084>
Comment 12 WebKit Review Bot 2012-08-08 14:04:57 PDT
All reviewed patches have been landed.  Closing bug.