Bug 93391 - [chromium] Move WebCompositor interface into Platform API
Summary: [chromium] Move WebCompositor interface into Platform API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 14:02 PDT by James Robinson
Modified: 2012-08-07 14:23 PDT (History)
8 users (show)

See Also:

Attachments
Patch (38.81 KB, patch)
2012-08-07 14:06 PDT, James Robinson 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-08-07 14:02:12 PDT 
[chromium] Move WebCompositor interface into Platform AP
Comment 1 James Robinson 2012-08-07 14:06:04 PDT 
Created attachment 156996 [details]
Patch
Comment 2 James Robinson 2012-08-07 14:08:38 PDT 
There are two motivations behind this:
1.) I'd like to add the "am I in threaded mode" getter to WebCompositor so that we don't have code all over WebCore depending on CCProxy to get at this data

2.) With this patch, users of the compositor can depend only on the Platform API instead of depending on the client API just for compositor initialization (which is a concern that goes away with GTFO, but is still nice in the short term).
Comment 3 WebKit Review Bot 2012-08-07 14:09:43 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adam Barth 2012-08-07 14:15:22 PDT 
Comment on attachment 156996 [details]
Patch

make sense.
Comment 5 James Robinson 2012-08-07 14:23:50 PDT 
Committed r124917: <http://trac.webkit.org/changeset/124917>