Bug 93364 - REGRESSION(r124865): It broke the ARM Chromium build
Summary: REGRESSION(r124865): It broke the ARM Chromium build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks: 91813
  Show dependency treegraph
 
Reported: 2012-08-07 06:56 PDT by Csaba Osztrogonác
Modified: 2012-08-07 11:56 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2012-08-07 08:48 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2012-08-07 08:50 PDT, Xingnan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-08-07 06:56:51 PDT
http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Chromium%20Release%20%28Build%29/builds/6774

cc1plus: warnings being treated as errors
Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:208: error: integer constant is too large for 'long' type
make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.o] Error 1
make: *** Waiting for unfinished jobs....
Comment 1 Joshua Bell 2012-08-07 08:48:46 PDT
Created attachment 156950 [details]
Patch
Comment 2 Xingnan Wang 2012-08-07 08:50:01 PDT
Created attachment 156952 [details]
Patch
Comment 3 Xingnan Wang 2012-08-07 08:53:52 PDT
(In reply to comment #2)
> Created an attachment (id=156952) [details]
> Patch

Opps, thank Joshua, ignore mine.
Comment 4 Joshua Bell 2012-08-07 08:55:05 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=156952) [details] [details]
> > Patch
> 
> Opps, thank Joshua, ignore mine.

Thought you'd be asleep. :) No worries, the patches are identical apart from ChangeLogs.
Comment 5 Csaba Osztrogonác 2012-08-07 08:57:35 PDT
Comment on attachment 156950 [details]
Patch

rs=me, the faster patch won. :) Thanks for the fix.
Comment 6 Csaba Osztrogonác 2012-08-07 11:56:10 PDT
Comment on attachment 156950 [details]
Patch

Clearing flags on attachment: 156950

Committed r124902: <http://trac.webkit.org/changeset/124902>
Comment 7 Csaba Osztrogonác 2012-08-07 11:56:16 PDT
All reviewed patches have been landed.  Closing bug.