RESOLVED FIXED 93360
[BlackBerry] GL scissor test is accidentally turned off 
https://bugs.webkit.org/show_bug.cgi?id=93360
Summary [BlackBerry] GL scissor test is accidentally turned off
Robin Cao
Reported 2012-08-07 05:51:16 PDT
The GL scissor test is accidentally turned off inside WebCore::LayerCompositingThread::drawTextures(). This is wrong and should be removed.
Attachments
patch (1.70 KB, patch)
2012-08-07 05:58 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2012-08-07 05:58:09 PDT
Created attachment 156922 [details] patch
Antonio Gomes
Comment 2 2012-08-07 06:11:16 PDT
Comment on attachment 156922 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=156922&action=review > Source/WebCore/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). > + > + The GL scissor test is accidentally turned off inside drawTextures(). > + This is wrong and should be removed. > + > + * platform/graphics/blackberry/LayerCompositingThread.cpp: we usually mentioned who reviewed internally, and what it fixes in practice.
George Staikos
Comment 3 2012-08-07 08:19:50 PDT
(In reply to comment #2) > (From update of attachment 156922 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156922&action=review > > > Source/WebCore/ChangeLog:12 > > + Reviewed by NOBODY (OOPS!). > > + > > + The GL scissor test is accidentally turned off inside drawTextures(). > > + This is wrong and should be removed. > > + > > + * platform/graphics/blackberry/LayerCompositingThread.cpp: > > we usually mentioned who reviewed internally, and what it fixes in practice. It fixes the world, really. It's like putting an exit() in the middle of the code somewhere. :)
WebKit Review Bot
Comment 4 2012-08-07 08:29:16 PDT
Comment on attachment 156922 [details] patch Clearing flags on attachment: 156922 Committed r124892: <http://trac.webkit.org/changeset/124892>
WebKit Review Bot
Comment 5 2012-08-07 08:29:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.