Bug 93360 - [BlackBerry] GL scissor test is accidentally turned off
Summary: [BlackBerry] GL scissor test is accidentally turned off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 05:51 PDT by Robin Cao
Modified: 2012-08-07 08:29 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.70 KB, patch)
2012-08-07 05:58 PDT, Robin Cao 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Cao 2012-08-07 05:51:16 PDT 
The GL scissor test is accidentally turned off inside WebCore::LayerCompositingThread::drawTextures().
This is wrong and should be removed.
Comment 1 Robin Cao 2012-08-07 05:58:09 PDT 
Created attachment 156922 [details]
patch
Comment 2 Antonio Gomes 2012-08-07 06:11:16 PDT 
Comment on attachment 156922 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156922&action=review

> Source/WebCore/ChangeLog:12
> +        Reviewed by NOBODY (OOPS!).
> +
> +        The GL scissor test is accidentally turned off inside drawTextures().
> +        This is wrong and should be removed.
> +
> +        * platform/graphics/blackberry/LayerCompositingThread.cpp:

we usually mentioned who reviewed internally, and what it fixes in practice.
Comment 3 George Staikos 2012-08-07 08:19:50 PDT 
(In reply to comment #2)
> (From update of attachment 156922 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156922&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        The GL scissor test is accidentally turned off inside drawTextures().
> > +        This is wrong and should be removed.
> > +
> > +        * platform/graphics/blackberry/LayerCompositingThread.cpp:
> 
> we usually mentioned who reviewed internally, and what it fixes in practice.

It fixes the world, really.  It's like putting an exit() in the middle of the code somewhere. :)
Comment 4 WebKit Review Bot 2012-08-07 08:29:16 PDT 
Comment on attachment 156922 [details]
patch

Clearing flags on attachment: 156922

Committed r124892: <http://trac.webkit.org/changeset/124892>
Comment 5 WebKit Review Bot 2012-08-07 08:29:20 PDT 
All reviewed patches have been landed.  Closing bug.