Bug 93351 - [Qt] Remove duplicated platform test expectations
Summary: [Qt] Remove duplicated platform test expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 04:27 PDT by Thiago Marcos P. Santos
Modified: 2012-08-14 04:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (171.64 KB, patch)
2012-08-07 04:43 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff
Patch (171.61 KB, patch)
2012-08-08 09:01 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff
Patch (171.61 KB, patch)
2012-08-10 00:34 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-08-07 04:27:52 PDT
Remove platform test expectations that are the same as the global expectations.
Comment 1 Thiago Marcos P. Santos 2012-08-07 04:43:22 PDT
Created attachment 156913 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-08-07 04:44:45 PDT
Comment on attachment 156913 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2012-08-07 04:51:01 PDT
Comment on attachment 156913 [details]
Patch

Rejecting attachment 156913 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
hing file LayoutTests/platform/qt/tables/mozilla/bugs/bug83786-expected.txt
rm 'LayoutTests/platform/qt/tables/mozilla/bugs/bug83786-expected.txt'
patching file LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt
rm 'LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13443830
Comment 4 Thiago Marcos P. Santos 2012-08-08 09:01:05 PDT
Created attachment 157231 [details]
Patch
Comment 5 WebKit Review Bot 2012-08-08 09:08:11 PDT
Comment on attachment 157231 [details]
Patch

Rejecting attachment 157231 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ugs/bug26553-expected.txt'
patching file LayoutTests/platform/qt/tables/mozilla/bugs/bug83786-expected.txt
rm 'LayoutTests/platform/qt/tables/mozilla/bugs/bug83786-expected.txt'
patching file LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt
rm 'LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13461193
Comment 6 Csaba Osztrogonác 2012-08-08 09:09:09 PDT
It seems something is wrong with your patch ...
Comment 7 Thiago Marcos P. Santos 2012-08-10 00:34:46 PDT
Created attachment 157653 [details]
Patch

I rewrote the patch from scratch. Let's see if EWS will be fine with it...
Comment 8 Thiago Marcos P. Santos 2012-08-10 01:36:56 PDT
(In reply to comment #7)
> Created an attachment (id=157653) [details]
> Patch
> 
> I rewrote the patch from scratch. Let's see if EWS will be fine with it...

Don't know what is the problem with SVN and my patch, really.
Comment 9 Csaba Osztrogonác 2012-08-13 04:10:07 PDT
Comment on attachment 157653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157653&action=review

> LayoutTests/ChangeLog:50
> +        * platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
> +        * platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
> +        * platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
> +        * platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
> +        * platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
> +        * platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
> +        * platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Removed.

These tests fail after removing these results, because there are orphaned 
expected file in platform/qt. I'll remove them too when I land your patch.

Otherwise LGTM, but I'll run a WK1 and a WK2 test before landing.
(Tools/Scripts/svn-apply applied the patch for me ... It seems
there is a bug somewhere in webkit-patch code ... )
Comment 10 Csaba Osztrogonác 2012-08-13 07:44:57 PDT
There are 2 more failing tests on Qt WK2:
 - editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
 - http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii.html

I'll fix them too.
Comment 11 Csaba Osztrogonác 2012-08-14 04:32:15 PDT
Landed in https://trac.webkit.org/changeset/125539.

Before landing I removed the orphaned svg results from platform/qt,
and added back results for editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html and http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii.html. We still need them. They are same as the platform
independent expected files, but we have different checked in results in platform/qt for WK1, so we have to have these results for WK2 in platform/qt-5.0-wk2.