Bug 93347 - showNodePath should show the age of ShadowRoot
Summary: showNodePath should show the age of ShadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 02:26 PDT by Shinya Kawanaka
Modified: 2012-08-08 00:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2012-08-07 22:25 PDT, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-08-07 02:26:55 PDT 
We would like to know the age of ShadowRoot.
I mean, the youngest is 0, the older shadow root of the youngest shadow root is 1.
Comment 1 Takashi Sakamoto 2012-08-07 22:25:12 PDT 
Created attachment 157113 [details]
Patch
Comment 2 Shinya Kawanaka 2012-08-07 23:00:07 PDT 
Comment on attachment 157113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157113&action=review

> Source/WebCore/dom/Node.cpp:2135
> +            for (ShadowRoot* shadowRoot = oldestShadowRootFor(toShadowRoot(node)->host()); shadowRoot && shadowRoot != node; shadowRoot = shadowRoot->youngerShadowRoot())

In this patch, the oldest shadow root is 0 and its younger shadow root is 1. Right?
I'm OK if it's consistent though.
Comment 3 WebKit Review Bot 2012-08-08 00:03:08 PDT 
Comment on attachment 157113 [details]
Patch

Clearing flags on attachment: 157113

Committed r125000: <http://trac.webkit.org/changeset/125000>
Comment 4 WebKit Review Bot 2012-08-08 00:03:11 PDT 
All reviewed patches have been landed.  Closing bug.