Bug 93346 - REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
Summary: REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords: NRWT
Depends on:
Blocks: 93026
  Show dependency tree / graph
 
Reported: 2012-08-07 01:55 PDT by Csaba Osztrogonác
Modified: 2012-08-07 02:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2012-08-07 02:04 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-08-07 01:55:56 PDT 
Fix is coming soon.
Comment 1 Csaba Osztrogonác 2012-08-07 02:04:24 PDT 
Created attachment 156896 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-08-07 02:07:16 PDT 
That's why we need "Unexpected" instead of "unexpected" in the result:

Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
-----------------------------------------------------------
...

    def _parseNewRunWebKitTestsOutput(self, logText):
        incorrectLayoutLines = []
        expressions = [
            ('flakes', re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)')),
            ('new passes', re.compile(r'Expected to .+, but passed:\s+\((\d+)\)')),
            ('missing results', re.compile(r'no expected results found\s*:\s+\((\d+)\)')),
            ('failures', re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)')),
        ]
        testFailures = {}
...
Comment 3 Simon Hausmann 2012-08-07 02:10:29 PDT 
Comment on attachment 156896 [details]
Patch

rs=me
Comment 4 Simon Hausmann 2012-08-07 02:10:49 PDT 
Comment on attachment 156896 [details]
Patch

rs=me
Comment 5 Csaba Osztrogonác 2012-08-07 02:15:38 PDT 
Committed r124870: <http://trac.webkit.org/changeset/124870>