Bug 93319 - [chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
Summary: [chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 18:50 PDT by James Robinson
Modified: 2012-08-06 20:37 PDT (History)
8 users (show)

See Also:


Attachments
Patch (15.80 KB, patch)
2012-08-06 18:51 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-08-06 18:50:11 PDT
[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
Comment 1 James Robinson 2012-08-06 18:51:24 PDT
Created attachment 156823 [details]
Patch
Comment 2 James Robinson 2012-08-06 18:52:18 PDT
Some cleanup that I've been sitting on for a while. This is prepwork for switching the PlatformLayer type over to WebLayer for the chromium port.
Comment 3 WebKit Review Bot 2012-08-06 18:52:40 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Antoine Labour 2012-08-06 18:54:59 PDT
LGTM
Comment 5 Adrienne Walker 2012-08-06 18:57:52 PDT
Comment on attachment 156823 [details]
Patch

R=me.  Maybe some day we can get rid of clearRenderSurface()...
Comment 6 James Robinson 2012-08-06 19:20:07 PDT
Comment on attachment 156823 [details]
Patch

Yeah, someday! Maybe separating the wrapper type from the type that RenderSurfaceChromium refers to will be the answer.
Comment 7 WebKit Review Bot 2012-08-06 20:37:40 PDT
Comment on attachment 156823 [details]
Patch

Clearing flags on attachment: 156823

Committed r124841: <http://trac.webkit.org/changeset/124841>
Comment 8 WebKit Review Bot 2012-08-06 20:37:45 PDT
All reviewed patches have been landed.  Closing bug.