Bug 93313 - [chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
Summary: [chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Labour
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 17:53 PDT by Antoine Labour
Modified: 2012-08-06 20:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2012-08-06 17:53 PDT, Antoine Labour 		no flags Details | Formatted Diff | Diff
Patch for landing (2.36 KB, patch)
2012-08-06 18:03 PDT, Antoine Labour 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Labour 2012-08-06 17:53:10 PDT 
[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
Comment 1 Antoine Labour 2012-08-06 17:53:59 PDT 
Created attachment 156814 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-06 17:55:55 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-08-06 17:56:41 PDT 
Comment on attachment 156814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:175
> +    virtual unsigned int insertSyncPoint() { return 0; }
> +    virtual void waitSyncPoint(unsigned int) { }

we normally just use "unsigned" as the type name in WebKit (although this isn't universal).
Comment 4 Antoine Labour 2012-08-06 18:03:46 PDT 
Created attachment 156815 [details]
Patch for landing
Comment 5 Antoine Labour 2012-08-06 18:04:26 PDT 
(In reply to comment #3)
> (From update of attachment 156814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review
> 
> > Source/Platform/chromium/public/WebGraphicsContext3D.h:175
> > +    virtual unsigned int insertSyncPoint() { return 0; }
> > +    virtual void waitSyncPoint(unsigned int) { }
> 
> we normally just use "unsigned" as the type name in WebKit (although this isn't universal).

Yep. Done.
Comment 6 WebKit Review Bot 2012-08-06 20:18:54 PDT 
Comment on attachment 156815 [details]
Patch for landing

Clearing flags on attachment: 156815

Committed r124840: <http://trac.webkit.org/changeset/124840>
Comment 7 WebKit Review Bot 2012-08-06 20:18:59 PDT 
All reviewed patches have been landed.  Closing bug.