Bug 93313 – [chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Labour]

[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D

[Antoine Labour]

Created attachment 156814 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 156814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:175
> +    virtual unsigned int insertSyncPoint() { return 0; }
> +    virtual void waitSyncPoint(unsigned int) { }

we normally just use "unsigned" as the type name in WebKit (although this isn't universal).

[Antoine Labour]

Created attachment 156815 [details]
Patch for landing

[Antoine Labour]

(In reply to comment #3)
> (From update of attachment 156814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review
> 
> > Source/Platform/chromium/public/WebGraphicsContext3D.h:175
> > +    virtual unsigned int insertSyncPoint() { return 0; }
> > +    virtual void waitSyncPoint(unsigned int) { }
> 
> we normally just use "unsigned" as the type name in WebKit (although this isn't universal).

Yep. Done.

[WebKit Review Bot]

Comment on attachment 156815 [details]
Patch for landing

Clearing flags on attachment: 156815

Committed r124840: <http://trac.webkit.org/changeset/124840>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.